Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

Commit 9d25de7

Browse files
committed
No fatal error on loop
1 parent 5579f27 commit 9d25de7

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/controllers/PermissionsController.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,16 @@ public function actionAddRelation($name)
137137
$model = new PermissionRelForm();
138138
if ($model->load(Yii::$app->request->post())) {
139139
$model->setPermission($perm);
140-
if ($model->addRelations()) {
141-
Yii::$app->session->setFlash('success', 'New relations added successfully.');
142-
} else {
143-
$errors = $model->getFirstErrors();
144-
Yii::$app->session->setFlash('warning', $errors ? reset($errors) : 'Some error occured.');
140+
//TODO make it no possible to choose loop created items
141+
try {
142+
if ($model->addRelations()) {
143+
Yii::$app->session->setFlash('success', 'New relations added successfully.');
144+
} else {
145+
$errors = $model->getFirstErrors();
146+
Yii::$app->session->setFlash('warning', $errors ? reset($errors) : 'Some error occured.');
147+
}
148+
} catch (\Exception $e) {
149+
Yii::$app->session->setFlash('warning', 'Hierarchy error');
145150
}
146151
}
147152

0 commit comments

Comments
 (0)