Add Kagenti → Rosso rebrand announcement banner#83
Conversation
Add a dismissible announcement banner at the top of the landing page noting the upcoming Kagenti → Rosso rename. Styled as a light red-tinted bar with a "NEW NAME" pill and a brand-red accent so it reads as a distinct announcement, separate from the (now hidden) event banner. - index.html: new #rebrand-banner; hide the KubeCon event banner - style.css: .banner-rebrand + .rebrand-pill styles - script.js: independent dismiss + session-storage persistence Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
3cffa27 to
3b13af7
Compare
mrsabath
left a comment
There was a problem hiding this comment.
Summary
Clean, well-scoped frontend change. The new #rebrand-banner reuses the existing .banner system, dismissRebrandBanner() mirrors the established dismiss pattern with session-storage persistence, the close button has a proper aria-label, and the styling notes AA contrast. No new patterns introduced, no secrets, and the KubeCon banner is hidden rather than deleted so it's trivial to restore.
On the rebrand content: I flagged during review that the "Kagenti → Rosso" announcement has no linkable authorization anywhere in the org (no issue, PR, discussion, or repo references "Rosso"). The maintainer has confirmed out-of-band that the rename is sanctioned, so approving on that basis. Recommend linking the official rebrand announcement/decision in the PR description before merge so the public-facing claim has a paper trail.
DCO: now passing — commit re-signed with Signed-off-by since the first review pass.
Areas reviewed: Frontend (HTML/CSS/JS), Security, Commit conventions
Author: Ibrahim2595 (MEMBER — maintainer)
Commits: 1, signed-off: yes
CI status: passing (DCO ✓, add-to-project ✓)
| </div> | ||
| </div> | ||
|
|
||
| <div class="banner hidden" id="event-banner"> |
There was a problem hiding this comment.
suggestion (non-blocking) — this adds hidden to the live KubeCon #event-banner so the rebrand message stands alone. Just confirming that's intended: KubeCon NA (Nov 9–12) is still upcoming, so you're trading the event promo for the rename notice. The markup is kept (only the class added), so restoring it later is a one-line revert — no concern there. Mentioning only so the event-banner drop is a conscious call, not a side effect.
|
@mrsabath @Ibrahim2595 I know this is already merged, but I wanted to mention that it deviates from our kagenti commit attribution policy (both the commit and PR description). Just wanted to flag for future reference since @Ibrahim2595 was likely not around when the policy was instituted. |
|
@rubambiza Thanks for pointing it out. The work was rushed/urgent and it was my first contribution. I'll make sure to follow the contribution description template in later work. |
Summary
Adds a dismissible announcement banner at the top of the landing page noting the upcoming Kagenti → Rosso rename:
It's styled as a light red-tinted bar with a brand-red accent and a
NEW NAMEpill, so it reads as a distinct announcement rather than blending into the existing dark event banner. The KubeCon event banner is hidden (markup kept, justhiddenclass added) so the rebrand message stands alone.Changes
#rebrand-banner; hide the KubeCon#event-banner.banner-rebrand+.rebrand-pillstyles (AA-compliant contrast)Notes
.bannersystem — no new patterns introduced.🤖 Generated with Claude Code