Skip to content

Commit 06d6934

Browse files
committed
remove standalone staticcheck dependency
On-behalf-of: @SAP [email protected]
1 parent 3dc8424 commit 06d6934

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

Makefile

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ GOLANGCI_LINT_VER := v1.62.2
5959
GOLANGCI_LINT_BIN := golangci-lint
6060
GOLANGCI_LINT := $(TOOLS_GOBIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
6161

62-
STATICCHECK_VER := 2024.1.1
63-
STATICCHECK_BIN := staticcheck
64-
STATICCHECK := $(TOOLS_GOBIN_DIR)/$(STATICCHECK_BIN)-$(STATICCHECK_VER)
65-
6662
GOTESTSUM_VER := v1.8.1
6763
GOTESTSUM_BIN := gotestsum
6864
GOTESTSUM := $(abspath $(TOOLS_DIR))/$(GOTESTSUM_BIN)-$(GOTESTSUM_VER)
@@ -140,9 +136,6 @@ install: require-jq require-go require-git verify-go-versions ## Install the pro
140136
$(GOLANGCI_LINT):
141137
GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
142138

143-
$(STATICCHECK):
144-
GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) honnef.co/go/tools/cmd/staticcheck $(STATICCHECK_BIN) $(STATICCHECK_VER)
145-
146139
$(LOGCHECK):
147140
GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) sigs.k8s.io/logtools/logcheck $(LOGCHECK_BIN) $(LOGCHECK_VER)
148141

@@ -152,9 +145,8 @@ $(CODE_GENERATOR):
152145
$(KCP_APIGEN_GEN):
153146
pushd . && cd sdk && GOBIN=$(TOOLS_GOBIN_DIR) go install ./cmd/apigen && popd
154147

155-
lint: $(GOLANGCI_LINT) $(STATICCHECK) $(LOGCHECK) ## Verify lint
148+
lint: $(GOLANGCI_LINT) $(LOGCHECK) ## Verify lint
156149
$(GOLANGCI_LINT) run --timeout 20m ./...
157-
$(STATICCHECK) -checks ST1019 ./...
158150
./hack/verify-contextual-logging.sh
159151
.PHONY: lint
160152

0 commit comments

Comments
 (0)