Merge pull request #3196 from embik/flush-and-exit-leaderelection

kcp-ci-bot · web-flow · commit 720cca19e35b · 2024-11-05T10:42:05.000+01:00
🐛 Terminate kcp process if controller installation fails
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -678,7 +678,7 @@ loop:
 						if len(s.controllers) == 0 {
 							if err = s.installControllers(ctx, controllerConfig, gvrs); err != nil {
 								logger.Error(err, "error in re-registering controllers")
-								return
+								klog.FlushAndExit(klog.ExitFlushTimeout, 1)
 							}
 						}
 						s.startControllers(leaderElectionCtx)

Original file line number	Diff line number	Diff line change
`@@ -678,7 +678,7 @@ loop:`
`678`	`678`	`if len(s.controllers) == 0 {`
`679`	`679`	`if err = s.installControllers(ctx, controllerConfig, gvrs); err != nil {`
`680`	`680`	`logger.Error(err, "error in re-registering controllers")`
`681`		`- return`
	`681`	`+ klog.FlushAndExit(klog.ExitFlushTimeout, 1)`
`682`	`682`	`}`
`683`	`683`	`}`
`684`	`684`	`s.startControllers(leaderElectionCtx)`