Skip to content

Commit d2102de

Browse files
committed
fix e2e
1 parent 79e87cd commit d2102de

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

pkg/server/localproxy.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -215,14 +215,17 @@ func WithLocalProxy(
215215
// If we want to re-use that code, we basically would be merging proxy with server packages.
216216
// Which is not desirable at the point of writing (2024.10-26), but might be in the future.
217217
func NewLocalProxyHandler(defaultHandler http.Handler, index index.Index, additionalMappingsFile string) (http.Handler, error) {
218-
mappingData, err := os.ReadFile(additionalMappingsFile)
219-
if err != nil {
220-
return nil, fmt.Errorf("failed to read mapping file %q: %w", additionalMappingsFile, err)
221-
}
222-
223218
var mapping []proxy.PathMapping
224-
if err = yaml.Unmarshal(mappingData, &mapping); err != nil {
225-
return nil, fmt.Errorf("failed to unmarshal mapping file %q: %w", additionalMappingsFile, err)
219+
if additionalMappingsFile != "" {
220+
mappingData, err := os.ReadFile(additionalMappingsFile)
221+
if err != nil {
222+
return nil, fmt.Errorf("failed to read mapping file %q: %w", additionalMappingsFile, err)
223+
}
224+
225+
var mapping []proxy.PathMapping
226+
if err = yaml.Unmarshal(mappingData, &mapping); err != nil {
227+
return nil, fmt.Errorf("failed to unmarshal mapping file %q: %w", additionalMappingsFile, err)
228+
}
226229
}
227230

228231
handlers := proxy.HttpHandler{

0 commit comments

Comments
 (0)