Fix/issue 203 distinct redis db numbers #264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve stdout/stderr handling in CLI.run_command() * Separate stdout and stderr capture * Better error reporting and debugging * Fix subprocess.run() usage - Remove code duplication in database user management * Create reusable __handle_db_user_changes() helper * Eliminate ~70 lines of duplicated code * Apply DRY principle - Enhance directory validation * Add robust __is_valid_kobo_install_directory() method * Multi-file validation (git repo + key files) * More reliable installation detection - Add customizable proxy port feature * Allow users to customize exposed_nginx_docker_port * Advanced mode option for external HTTP/HTTPS ports * Maintain backward compatibility - Fix bugs * Resolve undefined backend_role variable * Fix type hint compilation errors - Update .gitignore * Add Python best practices * Ignore venv, cache, IDE, and OS files - Update tests * Fix test mocks for new CLI.run_command() signature * Support both docker-compose and docker compose formats * All 34 config tests passing Fixes existing TODO comments and improves code maintainability.
- Changed REDIS_SESSION_URL from database /2 to /3 - Prevents conflict when redis-main and redis-cache point to same server - Particularly helpful for staging environments - Database number allocation: * /0: Enketo (redis-main, cannot be configured) * /1: Celery broker (redis-main) * /3: Django sessions (redis-cache) - CHANGED from /2 * /5: Django cache (redis-cache) * /6: Service account backend (redis-cache) - Resolves 3-year-old issue reported by @jnm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #203 - Use distinct Redis database numbers to prevent conflicts when redis-main and redis-cache point to the same server
Problem
When redis-main and redis-cache are configured to point to the same Redis server (common in staging environments), there was a database number conflict:
/2on redis-cache/1on redis-mainOriginal Issue Timeline: Reported 3 years ago by @jnm
Solution
Changed
REDIS_SESSION_URLfrom database/2to/3to ensure all database numbers are unique across both redis-main and redis-cache.Changes
templates/kobo-env/envfiles/databases.txt.tpl/2to/3REDIS_SESSION_URLnow uses database/3instead of/2Redis Database Allocation
After this fix, the database numbers are:
redis-main:
/0- Enketo (cannot be configured)/1- Celery broker (CELERY_BROKER_URL)redis-cache:
/3- Django sessions (REDIS_SESSION_URL) => CHANGED/5- Django cache (CACHE_URL)/6- Service account backend (SERVICE_ACCOUNT_BACKEND_URL)All numbers are now distinct, preventing any conflicts when both Redis services point to the same server.
Testing
Impact
Migration Notes
When upgrading to this version:
/3Related