Skip to content

Commit 84554bf

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]> Signed-off-by: Ryan Zhang <[email protected]>
1 parent 202a595 commit 84554bf

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

.github/copilot-instructions.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ The main idea is that we are creating a multi-cluster application management sol
77
## General Rules
88

99
- Use @terminal when answering questions about Git.
10-
- If your response to me is waiting on "OK", just proceed.
10+
- If you're waiting for my confirmation ("OK"), proceed without further prompting.
1111
- Follow the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md) if possible.
1212
- Favor using the standard library over third-party libraries.
1313
- Run goimports on save.
@@ -61,21 +61,21 @@ The main idea is that we are creating a multi-cluster application management sol
6161
## Testing Rules
6262

6363
- Unit test files should always be called `<go_file>_test.go` and be in the same directory
64-
+ Unit tests are normally written in a table-driven style
65-
+ Use `go test -v ./...` to run all tests under a directory.
66-
+ Run the tests from the packages that are modified and verify they pass.
67-
+ Share the analysis as to why a test is failing and propose a fix.
64+
- Unit tests are normally written in a table-driven style
65+
- Use `go test -v ./...` to run all tests under a directory.
66+
- Run the tests from the packages that are modified and verify they pass.
67+
- Share the analysis as to why a test is failing and propose a fix.
6868
- Integration test files should be called `<go_file>_integration_test.go` and can be in the same directory or under the `test` directory.
69-
+ Integration tests are normally written in a Ginkgo style.
69+
- Integration tests are normally written in a Ginkgo style.
7070
- E2E tests are all under the test/e2e directory.
71-
+ E2E tests are written in a Ginkgo style.
72-
+ E2E tests are run using `make e2e-tests` and are run against 3 kind clusters created by the scripts in the `test/e2e` directory.
73-
+ E2E tests are cleaned up using `make clean-e2e-tests`.
71+
- E2E tests are written in a Ginkgo style.
72+
- E2E tests are run using `make e2e-tests` and are run against 3 kind clusters created by the scripts in the `test/e2e` directory.
73+
- E2E tests are cleaned up using `make clean-e2e-tests`.
7474
- When adding tests to an existing file:
75-
+ Always re-use the existing test setup where possible.
76-
+ Only add imports if absolutely needed.
77-
+ Add tests to existing Context where it makes sense.
78-
+ When adding new tests in the Ginkgo style test, always add them to a new Context.
75+
- Always re-use the existing test setup where possible.
76+
- Only add imports if absolutely needed.
77+
- Add tests to existing Context where it makes sense.
78+
- When adding new tests in the Ginkgo style test, always add them to a new Context.
7979

8080
## Domain Knowledge
8181

0 commit comments

Comments
 (0)