-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(sdk): fix set_container_image within ParallelFor. Fixes #12413 #12414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fix set_container_image within ParallelFor. Fixes #12413 #12414
Conversation
Signed-off-by: Ousama Esbel <[email protected]>
|
Hi @uzi0espil. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/ok-to-test |
Signed-off-by: Ousama Esbel <[email protected]>
|
/assign |
|
/ok-to-test |
|
/ok-to-test |
zazulam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zazulam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This PR fixes a bug in PipelineTask.set_container_image where dependencies from PipelineChannels (like PipelineParameter or upstream task outputs) were not correctly registered if they were partA of a formatted string.
The previous implementation only checked if the entire name argument was a PipelineChannel instance. It did not handle cases where channels were embedded within a string.
This PR introduces logic to:
pipeline_channel.extract_pipeline_channels_from_any(name)to find all PipelineChannel instances embedded in thenameargument.self._channel_inputslist.This ensures that all dynamic dependencies used to construct the container image name are properly registered, allowing the KFP compiler to build the correct task execution graph.
Which issue(s) this PR fixes
Fixes #12413
Checklist: