Fixes bug in sandbox_client that assumed pod name matched the sandbox name

[igooch]

This pull request addresses a bug in the sandbox_client.py that caused it to fail when using a SandboxWarmPool. The client made incorrect assumptions about the naming of Sandbox and Pod resources when they are sourced from a warm pool, leading to "not found" errors.

Specifically, this pull request introduces the change:

Correct Pod Name for Port-Forwarding: The client now correctly identifies the pod name for port-forwarding by checking for the agents.x-k8s.io/pod-name annotation on the Sandbox resource. If the annotation is present (indicating the pod is from a sandbox warm pool), it uses the specified pod name. Otherwise, it falls back to using the Sandbox name, preserving the existing behavior for on-demand sandboxes.

This change make the Python client fully compatible with SandboxWarmPools.

Other changes are for autopep8 formatting only.

Fixes #149

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: igooch / name: Ivy Gooch (3be3770, e66fb1d)

[netlify]

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	3be3770
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/6913bde1f9a108000886e5ed

[k8s-ci-robot]

Welcome @igooch!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @igooch. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[aditya-shantanu]

Add a test in this PR or have a fast follow up.
Do we have the framework set up to be able to test the python client ?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aditya-shantanu, igooch
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[peterzhongyi]

Is this necessary for the bug fix?

[igooch]

Not for this particular error. It does help with other possible errors as it filters for only the relevant events in the watch.

[janetkuo]

/ok-to-test

[igooch]

Add a test in this PR or have a fast follow up. Do we have the framework set up to be able to test the python client ?

There is not currently a framework to test the python client. Also, as it stands the sandbox_client.py is quite specific to the agent-sandbox/examples/python-runtime-sandbox/main.py in that it assumes an /execute endpoint, assumes an exposed port, etc. That means this tests is dependent on having the python-runtime-sandbox image available to install into a sandboxtemplate and / or warmpool, and I don't believe this image has been publicly published yet.

So for an e2e test we'll either need to make this client more generic, or have a published version of the python-runtime-sandbox image available for the test to pull into the kind test cluster.