-
Notifications
You must be signed in to change notification settings - Fork 44
add example on aio-sandbox #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lize Cai <[email protected]>
✅ Deploy Preview for agent-sandbox canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lizzzcai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @lizzzcai! |
|
Hi @lizzzcai. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
barney-s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a great example for the aio-sandbox. It effectively showcases the core functionalities of the agent-sandbox.
I've added several comments with suggestions to enhance the example's robustness, clarity, and documentation. Please review and address them.
|
/ok-to-test |
Signed-off-by: Lize Cai <[email protected]>
|
Hi @barney-s , thanks for your review. I updated the PR to address most of your comments, can you help to take a look again, thanks. |
add an example on how to run aio-sandbox via agent-sandbox.