fix(chart): only enable nodeAllocatableUpdatePeriodSeconds for EKS 1.34+

[maxsxu]

What type of PR is this?

/kind bug

What is this PR about? / Why do we need it?

The MutableCSINodeAllocatableCount feature gate is enabled by default in EKS 1.34

Per the AWS documentation

There're also some issues reported when deploying on EKS < 1.34:

• EBS CSI DRIVER Volume attachment limit check on AL2023 Nodes #2387 (comment)

How was this change tested?

For EKS < 1.34

1. For a 1.33 EKS
2. Upgrade aws-ebs-csi-driver helm chart to this PR version

For EKS >= 1.34

1. Create a new 1.34 EKS
2. Deploy this aws-ebs-csi-driver helm chart

Does this PR introduce a user-facing change?

N/A

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elijahquinones for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @maxsxu!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @maxsxu. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[torredil]

Kubernetes API server already automatically drops the field when the feature gate is not enabled: https://github.com/kubernetes/kubernetes/blob/95bff1b249e048b7e36ae857d7478dd2ac05346a/pkg/registry/storage/csidriver/strategy.go#L47.

Another point to consider is that this would be a breaking change for users on self-managed clusters with the feature gate enabled on 1.33 that are already relying on the existing rendering logic.