Skip to content

Commit 362cde0

Browse files
committed
Respond to comments
1 parent 30eee08 commit 362cde0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

docs/errors.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ kubectl logs -n kube-system -l app=csi-azurelustre-controller -c azurelustre --t
172172
- This should return output such as:
173173

174174
```text
175-
There is not enough room in the /subscriptions/<sub-id>/resourceGroups/<rg>/providers/Microsoft.Network/virtualNetworks/<vnet>/subnets/<subnet> subnetID to fit a AMLFS-Durable-Premium-40 SKU cluster: 10 needed, 3 available
175+
There is not enough room in the /subscriptions/<sub-id>/resourceGroups/<rg>/providers/Microsoft.Network/virtualNetworks/<vnet>/subnets/<subnet> subnet to fit a AMLFS-Durable-Premium-40 SKU cluster: 10 needed, 3 available
176176
```
177177

178178
- Verify subnet details in Azure portal

pkg/azurelustre/controllerserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const (
6161

6262
var (
6363
timeRegexp = regexp.MustCompile(`^([01]?[0-9]|2[0-3]):[0-5][0-9]$`)
64-
amlFilesystemNameRegex = regexp.MustCompile(`^[a-zA-Z0-9][a-zA-Z0-9_-]{0,78}[a-zA-Z0-9]$`)
64+
amlFilesystemNameRegex = regexp.MustCompile(fmt.Sprintf(`^[a-zA-Z0-9][a-zA-Z0-9_-]{0,%d}[a-zA-Z0-9]$`, amlFilesystemNameMaxLength-2))
6565
)
6666

6767
type SubnetProperties struct {

pkg/azurelustre/dynamic_provisioning.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,9 @@ func (d *DynamicProvisioner) CheckSubnetCapacity(ctx context.Context, subnetInfo
469469
}
470470

471471
if requiredSubnetIPSize > availableIPs {
472-
klog.Warningf("There is not enough room in the %s subnetID to fit a %s SKU cluster: %v needed, %v available", subnetInfo.SubnetID, sku, requiredSubnetIPSize, availableIPs)
472+
klog.Warningf("There is not enough room in the %s subnet to fit a %s SKU cluster: %v needed, %v available", subnetInfo.SubnetID, sku, requiredSubnetIPSize, availableIPs)
473473
return false, nil
474474
}
475-
klog.V(2).Infof("There is enough room in the %s subnetID to fit a %s SKU cluster: %v needed, %v available", subnetInfo.SubnetID, sku, requiredSubnetIPSize, availableIPs)
475+
klog.V(2).Infof("There is enough room in the %s subnet to fit a %s SKU cluster: %v needed, %v available", subnetInfo.SubnetID, sku, requiredSubnetIPSize, availableIPs)
476476
return true, nil
477477
}

0 commit comments

Comments
 (0)