Add skip for interfaces in unknown state to entrypoint script #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
approved
jeffbearer
reviewed
Nov 11, 2024
pkg/azurelustreplugin/entrypoint.sh
Outdated
| elif [[ "$interface_info" =~ 'link/ether' ]]; then | ||
| echo "$(date -u) Including ethernet interface: ${interface}" | ||
| ethernet_interfaces+=("$interface") | ||
| elif [[ "$interface_info" =~ 'UNKNOWN' ]]; then |
There was a problem hiding this comment.
Is there a list of all (common) kinds of interfaces that we should consult and also exclude? Token Ring, ATM, Sneakernet?
t-mialve
commented
Nov 11, 2024
pkg/azurelustreplugin/entrypoint.sh
Outdated
| ethernet_interfaces+=("$interface") | ||
| elif [[ "$interface_info" =~ 'UNKNOWN' ]]; then | ||
| echo "$(date -u) Not adding state unknown interface: ${interface}" | ||
| continue |
Collaborator
Author
There was a problem hiding this comment.
Remove the continues
t-mialve
force-pushed
the
t-mialve/skip-unknown-interfaces
branch
2 times, most recently
from
52ecd88 to
73e0b74
Compare
t-mialve
force-pushed
the
t-mialve/skip-unknown-interfaces
branch
from
73e0b74 to
6f8f102
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dabradley, t-mialve The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Skips interfaces that are in an UNKNOWN state. If these aren't skipped it may cause extra client IPs to be added.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: