Skip to content

Commit 29122d4

Browse files
authored
Merge pull request #12848 from arshadd-b/fix-resourceVersion-flake
🐛 Fix objects with Changed Resource Versions flake
2 parents 31a7860 + 2256190 commit 29122d4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/framework/resourceversion_helpers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ func ValidateResourceVersionStable(ctx context.Context, proxy ClusterProxy, name
4949
}()
5050
// This is intentionally failing on the first run.
5151
g.Expect(objectsWithResourceVersion).To(BeComparableTo(previousResourceVersions))
52-
}, 1*time.Minute, 15*time.Second).Should(Succeed(), "resourceVersions never became stable")
52+
}, 2*time.Minute, 15*time.Second).MustPassRepeatedly(4).Should(Succeed(), "resourceVersions never became stable")
5353

5454
// Verify resourceVersions are stable for a while.
5555
byf("Check resourceVersions remain stable")
5656
Consistently(func(g Gomega) {
5757
objectsWithResourceVersion, objects, err := getObjectsWithResourceVersion(ctx, proxy, namespace, ownerGraphFilterFunction)
5858
g.Expect(err).ToNot(HaveOccurred())
5959
g.Expect(previousResourceVersions).To(BeComparableTo(objectsWithResourceVersion), printObjectDiff(previousObjects, objects))
60-
}, 2*time.Minute, 15*time.Second).Should(Succeed(), "resourceVersions didn't stay stable")
60+
}, 2*time.Minute, 5*time.Second).Should(Succeed(), "resourceVersions didn't stay stable")
6161
}
6262

6363
func printObjectDiff(previousObjects, newObjects map[string]client.Object) func() string {

0 commit comments

Comments
 (0)