Skip to content

🌱 enhance mhc events #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

🌱 enhance mhc events #12930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6992d
Add event for remediation in MachineHealthCheck
nayuta723 Oct 26, 2025
1bd0780
Improve MachineHealthCheck event messages
nayuta723 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,10 +535,17 @@ func (r *Reconciler) patchUnhealthyTargets(ctx context.Context, logger logr.Logg
t.Machine,
corev1.EventTypeNormal,
EventMachineMarkedUnhealthy,
"Machine %s has been marked as unhealthy by %s",
klog.KObj(t.Machine),
"Marked as unhealthy by MachineHealthCheck %s",
klog.KObj(t.MHC),
)
// Record event on MachineHealthCheck to track remediation history
r.recorder.Eventf(
m,
corev1.EventTypeNormal,
EventMachineMarkedUnhealthy,
"Observed machine %s is now marked as unhealthy",
klog.KObj(t.Machine),
)
}
return errList
}
Expand Down