fix: cloudflare softError failedZones (#5899)

nissessenap · web-flow · commit 6e9d459d8d09 · 2025-10-13T00:00:55.000-07:00
Right now we get a fatal due to dual DNS records.
Instead do a softError and try again next reconcile.

Signed-off-by: Edvin Norling &lt;edvin.norling@kognic.com&gt;
diff --git a/provider/cloudflare/cloudflare.go b/provider/cloudflare/cloudflare.go
@@ -721,7 +721,7 @@ func (p *CloudFlareProvider) submitChanges(ctx context.Context, changes []*cloud
 	}
 
 	if len(failedZones) > 0 {
-		return fmt.Errorf("failed to submit all changes for the following zones: %q", failedZones)
+		return provider.NewSoftErrorf("failed to submit all changes for the following zones: %q", failedZones)
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -721,7 +721,7 @@ func (p CloudFlareProvider) submitChanges(ctx context.Context, changes []cloud`
`721`	`721`	`}`
`722`	`722`
`723`	`723`	`if len(failedZones) > 0 {`
`724`		`- return fmt.Errorf("failed to submit all changes for the following zones: %q", failedZones)`
	`724`	`+ return provider.NewSoftErrorf("failed to submit all changes for the following zones: %q", failedZones)`
`725`	`725`	`}`
`726`	`726`
`727`	`727`	`return nil`