perf(endpoint): optimize ProviderSpecific to use map for O(1) access

Author: u-kai

apis/v1alpha1/dnsendpoint.go

@@ -52,6 +52,7 @@ type DNSEndpointSpec struct {
 	Endpoints []*Endpoint `json:"endpoints"`
 }
 
+// ProviderSpecificProperty holds the name and value of a configuration which is specific to individual DNS providers
 type ProviderSpecificProperty struct {
 	Name  string `json:"name,omitempty"`
 	Value string `json:"value,omitempty"`

endpoint/endpoint.go

@@ -206,14 +206,54 @@ func (t Targets) IsLess(o Targets) bool {
 	return false
 }
 
-// ProviderSpecificProperty holds the name and value of a configuration which is specific to individual DNS providers
-type ProviderSpecificProperty struct {
-	Name  string `json:"name,omitempty"`
-	Value string `json:"value,omitempty"`
+// ProviderSpecific holds configuration which is specific to individual DNS providers
+type ProviderSpecific map[string]string
+
+func (ps ProviderSpecific) Set(key, value string) {
+	ps[key] = value
 }
 
-// ProviderSpecific holds configuration which is specific to individual DNS providers
-type ProviderSpecific []ProviderSpecificProperty
+func (ps ProviderSpecific) Get(key string) (string, bool) {
+	value, ok := ps[key]
+	return value, ok
+}
+
+func (ps ProviderSpecific) Delete(key string) {
+	delete(ps, key)
+}
+
+// String returns a stable, backwards-compatible string form.
+// For compatibility with older branches where ProviderSpecific was
+// []ProviderSpecificProperty, we render:
+// - empty or nil as "[]"
+// - non-empty as slice-like entries sorted by key, e.g. "[{k1 v1} {k2 v2}]"
+// This preserves previous log expectations and keeps output deterministic.
+func (ps ProviderSpecific) String() string {
+	if len(ps) == 0 {
+		return "[]"
+	}
+	// Collect and sort keys for stable output.
+	keys := make([]string, 0, len(ps))
+	for k := range ps {
+		keys = append(keys, k)
+	}
+	sort.Strings(keys)
+	// Build entries like "{key value}" preserving stable order.
+	b := strings.Builder{}
+	b.WriteByte('[')
+	for i, k := range keys {
+		if i > 0 {
+			b.WriteByte(' ')
+		}
+		b.WriteByte('{')
+		b.WriteString(k)
+		b.WriteByte(' ')
+		b.WriteString(ps[k])
+		b.WriteByte('}')
+	}
+	b.WriteByte(']')
+	return b.String()
+}
 
 // EndpointKey is the type of a map key for separating endpoints or targets.
 type EndpointKey struct {
@@ -224,7 +264,6 @@ type EndpointKey struct {
 }
 
 // Endpoint is a high-level way of a connection between a service and an IP
-// +kubebuilder:object:generate=true
 type Endpoint struct {
 	// The hostname of the DNS record
 	DNSName string `json:"dnsName,omitempty"`
@@ -293,37 +332,26 @@ func (e *Endpoint) WithProviderSpecific(key, value string) *Endpoint {
 
 // GetProviderSpecificProperty returns the value of a ProviderSpecificProperty if the property exists.
 func (e *Endpoint) GetProviderSpecificProperty(key string) (string, bool) {
-	for _, providerSpecific := range e.ProviderSpecific {
-		if providerSpecific.Name == key {
-			return providerSpecific.Value, true
-		}
+	if e.ProviderSpecific == nil {
+		return "", false
 	}
-	return "", false
+	return e.ProviderSpecific.Get(key)
 }
 
 // SetProviderSpecificProperty sets the value of a ProviderSpecificProperty.
 func (e *Endpoint) SetProviderSpecificProperty(key string, value string) {
-	for i, providerSpecific := range e.ProviderSpecific {
-		if providerSpecific.Name == key {
-			e.ProviderSpecific[i] = ProviderSpecificProperty{
-				Name:  key,
-				Value: value,
-			}
-			return
-		}
+	if e.ProviderSpecific == nil {
+		e.ProviderSpecific = make(ProviderSpecific)
 	}
-
-	e.ProviderSpecific = append(e.ProviderSpecific, ProviderSpecificProperty{Name: key, Value: value})
+	e.ProviderSpecific.Set(key, value)
 }
 
 // DeleteProviderSpecificProperty deletes any ProviderSpecificProperty of the specified name.
 func (e *Endpoint) DeleteProviderSpecificProperty(key string) {
-	for i, providerSpecific := range e.ProviderSpecific {
-		if providerSpecific.Name == key {
-			e.ProviderSpecific = append(e.ProviderSpecific[:i], e.ProviderSpecific[i+1:]...)
-			return
-		}
+	if e.ProviderSpecific == nil {
+		return
 	}
+	e.ProviderSpecific.Delete(key)
 }
 
 // WithLabel adds or updates a label for the Endpoint.