Skip to content

Commit 5358b62

Browse files
illumeillume
committed
frontend: Notifications: Disable Notifications
There's a number of problems with Notifications. With some clusters the number of warnings makes it not useful. Because they keep showing new notifications over and over again. The idea is to disable it for now, and revisit it again once we can prove that it is working well. Signed-off-by: René Dudfield <[email protected]>
1 parent 24f2322 commit 5358b62

File tree

2 files changed

+2
-142
lines changed

2 files changed

+2
-142
lines changed

‎frontend/src/components/App/TopBar.tsx‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import { drawerWidth } from '../Sidebar';
3535
import HeadlampButton from '../Sidebar/HeadlampButton';
3636
import { setWhetherSidebarOpen } from '../Sidebar/sidebarSlice';
3737
import { AppLogo } from './AppLogo';
38-
import Notifications from './Notifications';
3938

4039
export interface TopBarProps {}
4140

@@ -328,11 +327,7 @@ export function PureTopBar({
328327
...appBarActions,
329328
{
330329
id: DefaultAppBarAction.NOTIFICATION,
331-
action: (
332-
<MenuItem onClick={handleMenuClose}>
333-
<Notifications />
334-
</MenuItem>
335-
),
330+
action: null,
336331
},
337332
{
338333
id: DefaultAppBarAction.SETTINGS,
@@ -391,7 +386,7 @@ export function PureTopBar({
391386
...appBarActions,
392387
{
393388
id: DefaultAppBarAction.NOTIFICATION,
394-
action: <Notifications />,
389+
action: null,
395390
},
396391
{
397392
id: DefaultAppBarAction.SETTINGS,

‎frontend/src/components/App/__snapshots__/TopBar.stories.storyshot‎

Lines changed: 0 additions & 135 deletions
Original file line numberDiff line numberDiff line change
@@ -23,33 +23,6 @@ exports[`Storyshots TopBar No Token 1`] = `
2323
<div
2424
class="makeStyles-clusterTitle"
2525
/>
26-
<button
27-
aria-controls=""
28-
aria-haspopup="true"
29-
aria-label="Show notifications"
30-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
31-
tabindex="0"
32-
type="button"
33-
>
34-
<svg
35-
aria-hidden="true"
36-
height="1em"
37-
preserveAspectRatio="xMidYMid meet"
38-
role="img"
39-
viewBox="0 0 24 24"
40-
width="1em"
41-
xmlns="http://www.w3.org/2000/svg"
42-
xmlns:xlink="http://www.w3.org/1999/xlink"
43-
>
44-
<path
45-
d="M21 19v1H3v-1l2-2v-6c0-3.1 2.03-5.83 5-6.71V4a2 2 0 0 1 2-2a2 2 0 0 1 2 2v.29c2.97.88 5 3.61 5 6.71v6l2 2m-7 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2"
46-
fill="currentColor"
47-
/>
48-
</svg>
49-
<span
50-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
51-
/>
52-
</button>
5326
</div>
5427
</nav>
5528
</div>
@@ -78,33 +51,6 @@ exports[`Storyshots TopBar One Cluster 1`] = `
7851
<div
7952
class="makeStyles-clusterTitle"
8053
/>
81-
<button
82-
aria-controls=""
83-
aria-haspopup="true"
84-
aria-label="Show notifications"
85-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
86-
tabindex="0"
87-
type="button"
88-
>
89-
<svg
90-
aria-hidden="true"
91-
height="1em"
92-
preserveAspectRatio="xMidYMid meet"
93-
role="img"
94-
viewBox="0 0 24 24"
95-
width="1em"
96-
xmlns="http://www.w3.org/2000/svg"
97-
xmlns:xlink="http://www.w3.org/1999/xlink"
98-
>
99-
<path
100-
d="M21 19v1H3v-1l2-2v-6c0-3.1 2.03-5.83 5-6.71V4a2 2 0 0 1 2-2a2 2 0 0 1 2 2v.29c2.97.88 5 3.61 5 6.71v6l2 2m-7 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2"
101-
fill="currentColor"
102-
/>
103-
</svg>
104-
<span
105-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
106-
/>
107-
</button>
10854
<button
10955
aria-controls="primary-user-menu"
11056
aria-haspopup="true"
@@ -149,33 +95,6 @@ exports[`Storyshots TopBar Processor Action 1`] = `
14995
<p>
15096
meow
15197
</p>
152-
<button
153-
aria-controls=""
154-
aria-haspopup="true"
155-
aria-label="Show notifications"
156-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
157-
tabindex="0"
158-
type="button"
159-
>
160-
<svg
161-
aria-hidden="true"
162-
height="1em"
163-
preserveAspectRatio="xMidYMid meet"
164-
role="img"
165-
viewBox="0 0 24 24"
166-
width="1em"
167-
xmlns="http://www.w3.org/2000/svg"
168-
xmlns:xlink="http://www.w3.org/1999/xlink"
169-
>
170-
<path
171-
d="M21 19v1H3v-1l2-2v-6c0-3.1 2.03-5.83 5-6.71V4a2 2 0 0 1 2-2a2 2 0 0 1 2 2v.29c2.97.88 5 3.61 5 6.71v6l2 2m-7 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2"
172-
fill="currentColor"
173-
/>
174-
</svg>
175-
<span
176-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
177-
/>
178-
</button>
17998
</div>
18099
</nav>
181100
</div>
@@ -204,33 +123,6 @@ exports[`Storyshots TopBar Token 1`] = `
204123
<div
205124
class="makeStyles-clusterTitle"
206125
/>
207-
<button
208-
aria-controls=""
209-
aria-haspopup="true"
210-
aria-label="Show notifications"
211-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
212-
tabindex="0"
213-
type="button"
214-
>
215-
<svg
216-
aria-hidden="true"
217-
height="1em"
218-
preserveAspectRatio="xMidYMid meet"
219-
role="img"
220-
viewBox="0 0 24 24"
221-
width="1em"
222-
xmlns="http://www.w3.org/2000/svg"
223-
xmlns:xlink="http://www.w3.org/1999/xlink"
224-
>
225-
<path
226-
d="M21 19v1H3v-1l2-2v-6c0-3.1 2.03-5.83 5-6.71V4a2 2 0 0 1 2-2a2 2 0 0 1 2 2v.29c2.97.88 5 3.61 5 6.71v6l2 2m-7 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2"
227-
fill="currentColor"
228-
/>
229-
</svg>
230-
<span
231-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
232-
/>
233-
</button>
234126
</div>
235127
</nav>
236128
</div>
@@ -275,33 +167,6 @@ exports[`Storyshots TopBar Two Cluster 1`] = `
275167
/>
276168
</button>
277169
</div>
278-
<button
279-
aria-controls=""
280-
aria-haspopup="true"
281-
aria-label="Show notifications"
282-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
283-
tabindex="0"
284-
type="button"
285-
>
286-
<svg
287-
aria-hidden="true"
288-
height="1em"
289-
preserveAspectRatio="xMidYMid meet"
290-
role="img"
291-
viewBox="0 0 24 24"
292-
width="1em"
293-
xmlns="http://www.w3.org/2000/svg"
294-
xmlns:xlink="http://www.w3.org/1999/xlink"
295-
>
296-
<path
297-
d="M21 19v1H3v-1l2-2v-6c0-3.1 2.03-5.83 5-6.71V4a2 2 0 0 1 2-2a2 2 0 0 1 2 2v.29c2.97.88 5 3.61 5 6.71v6l2 2m-7 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2"
298-
fill="currentColor"
299-
/>
300-
</svg>
301-
<span
302-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
303-
/>
304-
</button>
305170
<button
306171
aria-controls="primary-user-menu"
307172
aria-haspopup="true"

0 commit comments

Comments
 (0)