Skip to content

Commit 56265ef

Browse files
committed
add warning to container-log* flags
1 parent 9d469f5 commit 56265ef

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

hack/ci/e2e-k8s.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ kubeadmConfigPatches:
116116
- |
117117
kind: ClusterConfiguration
118118
apiVersion: kubeadm.k8s.io/v1beta4
119-
metadata:
120-
name: config
121119
apiServer:
122120
extraArgs:
123121
- name: "v"
@@ -148,6 +146,10 @@ kubeadmConfigPatches:
148146
kubeletExtraArgs:
149147
- name: "v"
150148
value: "${KIND_CLUSTER_LOG_LEVEL}"
149+
# Warning: these flags appear to be load bearing / impact performance
150+
# See: https://github.com/kubernetes-sigs/kind/pull/4046
151+
# Be careful when updating these.
152+
# Most CI jobs should not need them, but some CI jobs might.
151153
- name: "container-log-max-files"
152154
value: "10"
153155
- name: "container-log-max-size"
@@ -156,8 +158,6 @@ kubeadmConfigPatches:
156158
- |
157159
kind: ClusterConfiguration
158160
apiVersion: kubeadm.k8s.io/v1beta3
159-
metadata:
160-
name: config
161161
apiServer:
162162
extraArgs:
163163
"v": "${KIND_CLUSTER_LOG_LEVEL}"
@@ -181,6 +181,10 @@ kubeadmConfigPatches:
181181
nodeRegistration:
182182
kubeletExtraArgs:
183183
"v": "${KIND_CLUSTER_LOG_LEVEL}"
184+
# Warning: these flags appear to be load bearing / impact performance
185+
# See: https://github.com/kubernetes-sigs/kind/pull/4046
186+
# Be careful when updating these.
187+
# Most CI jobs should not need them, but some CI jobs might.
184188
"container-log-max-files": "10"
185189
"container-log-max-size": "100Mi"
186190
EOF

0 commit comments

Comments
 (0)