Update golangci-lint to v2.3.1

Golangci-lint has released a new major version that includes some
changes to how it is configured, along with the usual linter updates
that come with every release.

This updates the golangci-lint version we use to v2.3.1 (the current
latest release) and updates the config file to conform to the new
format. Also includes quite a few trivial updates to address the new
warnings from the updated linters.

Signed-off-by: Sean McGinnis <[email protected]>

Author: stmcginnis

cmd/kind/app/main.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package app is the implementation of the kind application.
 package app
 
 import (

cmd/kind/main.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package main is the main entrypoint for the kind cli.
 package main
 
 import (

hack/make-rules/verify/lint.sh

@@ -23,7 +23,7 @@ source hack/build/setup-go.sh
 
 # build golangci-lint
 cd "${REPO_ROOT}/hack/tools"
-go build -o "${REPO_ROOT}"/bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
+go build -o "${REPO_ROOT}"/bin/golangci-lint github.com/golangci/golangci-lint/v2/cmd/golangci-lint
 cd "${REPO_ROOT}"
 
 # first for the repo in general

hack/tools/.golangci.yml

@@ -1,33 +1,62 @@
+version: "2"
+
 run:
   timeout: 3m
 
 linters:
-  disable-all: true
+  default: none
+
   enable:
     - errcheck
-    - gosimple
     - govet
     - ineffassign
     - staticcheck
-    - typecheck
     - gochecknoinits
-    - gofmt
     - revive # replaces golint for now
     - misspell
-    - exportloopref
     - unparam
 
-linters-settings:
-  staticcheck:
-    checks:
-    - all
+  settings:
+    staticcheck:
+      checks:
+        - all
+    revive:
+      rules:
+        - name: var-naming
+          arguments:
+            - []
+            - []
+            - - skip-package-name-checks: true
+
+  exclusions:
+    presets:
+      - std-error-handling
+      - common-false-positives
+    rules:
+      # this requires renaming all unused parameters, we'd rather leave a preferred
+      # placeholder name in place when implementing an interface etc.
+      # we can revisit this later, right now it's generating a lot of new warnings
+      # after upgrading golangci-lint
+      - linters:
+          - revive
+        text: "^unused-parameter: .*"
+      # Not all package docstrings add value, so we do not want to enforce it
+      - linters:
+          - revive
+        text: "package-comments: should have a package comment"
+      - linters:
+          - staticcheck
+        text: "ST1000: at least one file in a package should have a package comment"
+      - linters:
+          - staticcheck
+        path: pkg/cmd
+        text: "ST1005: error strings should not be capitalized"
+      - linters:
+          - staticcheck
+        path: images/kindnetd/cmd
+        text: "ST1005: error strings should not be capitalized"
+
+formatters:
+  enable:
+    - gofmt
 
-issues:
-  exclude-rules:
-    # this requires renaming all unused parameters, we'd rather leave a preferred
-    # placeholder name in place when implementing an interface etc.
-    # we can revisit this later, right now it's generating a lot of new warnings
-    # after upgrading golangci-lint
-    - text: "^unused-parameter: .*"
-      linters:
-        - revive