generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 256
Open
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Description
Feature Description
Currently kro does not detect breaking changes in ResourceGroup schemas when users modify them. Breaking changes like adding new required fields or removing existing fields can cause instance reconciliation failures. we need to add support for detecting such changes and marking the ResourceGroup as invalid. The system should also support an annotation
(kro.run/allow-breaking-changes: "true") to explicitly allow these changes when needed.
Examples:
# Original ResourceGroup schema
apiVersion: kro.run/v1alpha1
kind: ResourceGroup
metadata:
name: my-application
spec:
schema:
spec:
name: string
image: string | default="nginx"# Breaking change - adding a required field without default value
apiVersion: kro.run/v1alpha1
kind: ResourceGroup
metadata:
name: my-application
annotations:
kro.run/allow-breaking-changes: "true" # Required to apply breaking changes
spec:
schema:
spec:
name: string
image: string | default="nginx"
port: number | require=true # Breaking change: new required fieldMetadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.