Merge pull request #2847 from Kavinjsir/fix/nit

k8s-ci-robot · web-flow · commit 5c949c2e50ca · 2022-08-03T01:47:53.000-07:00
🌱 grafana/v1-alpha: correct title and description syntax
diff --git a/pkg/plugins/optional/grafana/v1alpha/scaffolds/internal/templates/runtime.go b/pkg/plugins/optional/grafana/v1alpha/scaffolds/internal/templates/runtime.go
@@ -105,7 +105,7 @@ const controllerRuntimeTemplate = `{
     },
     {
       "datasource": "${DS_PROMETHEUS}",
-      "description": "Total number of reconciliation per controller",
+      "description": "Total number of reconciliations per controller",
       "fieldConfig": {
         "defaults": {
           "color": {
@@ -187,7 +187,7 @@ const controllerRuntimeTemplate = `{
           "refId": "A"
         }
       ],
-      "title": "Reconciliation Total Count Per Controller",
+      "title": "Total Reconciliation Count Per Controller",
       "type": "timeseries"
     },
     {
diff --git a/testdata/project-v3-addon-and-grafana/grafana/controller-runtime-metrics.json b/testdata/project-v3-addon-and-grafana/grafana/controller-runtime-metrics.json
@@ -60,7 +60,7 @@
     },
     {
       "datasource": "${DS_PROMETHEUS}",
-      "description": "Total number of reconciliation per controller",
+      "description": "Total number of reconciliations per controller",
       "fieldConfig": {
         "defaults": {
           "color": {
@@ -142,7 +142,7 @@
           "refId": "A"
         }
       ],
-      "title": "Reconciliation Total Count Per Controller",
+      "title": "Total Reconciliation Count Per Controller",
       "type": "timeseries"
     },
     {
diff --git a/testdata/project-v4-addon-and-grafana/grafana/controller-runtime-metrics.json b/testdata/project-v4-addon-and-grafana/grafana/controller-runtime-metrics.json
@@ -60,7 +60,7 @@
     },
     {
       "datasource": "${DS_PROMETHEUS}",
-      "description": "Total number of reconciliation per controller",
+      "description": "Total number of reconciliations per controller",
       "fieldConfig": {
         "defaults": {
           "color": {
@@ -142,7 +142,7 @@
           "refId": "A"
         }
       ],
-      "title": "Reconciliation Total Count Per Controller",
+      "title": "Total Reconciliation Count Per Controller",
       "type": "timeseries"
     },
     {

Original file line number	Diff line number	Diff line change
@@ -105,7 +105,7 @@ const controllerRuntimeTemplate = `{
`105`	`105`	`},`
`106`	`106`	`{`
`107`	`107`	`"datasource": "${DS_PROMETHEUS}",`
`108`		`- "description": "Total number of reconciliation per controller",`
	`108`	`+ "description": "Total number of reconciliations per controller",`
`109`	`109`	`"fieldConfig": {`
`110`	`110`	`"defaults": {`
`111`	`111`	`"color": {`
@@ -187,7 +187,7 @@ const controllerRuntimeTemplate = `{
`187`	`187`	`"refId": "A"`
`188`	`188`	`}`
`189`	`189`	`],`
`190`		`- "title": "Reconciliation Total Count Per Controller",`
	`190`	`+ "title": "Total Reconciliation Count Per Controller",`
`191`	`191`	`"type": "timeseries"`
`192`	`192`	`},`
`193`	`193`	`{`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@`
`60`	`60`	`},`
`61`	`61`	`{`
`62`	`62`	`"datasource": "${DS_PROMETHEUS}",`
`63`		`- "description": "Total number of reconciliation per controller",`
	`63`	`+ "description": "Total number of reconciliations per controller",`
`64`	`64`	`"fieldConfig": {`
`65`	`65`	`"defaults": {`
`66`	`66`	`"color": {`
`@@ -142,7 +142,7 @@`
`142`	`142`	`"refId": "A"`
`143`	`143`	`}`
`144`	`144`	`],`
`145`		`- "title": "Reconciliation Total Count Per Controller",`
	`145`	`+ "title": "Total Reconciliation Count Per Controller",`
`146`	`146`	`"type": "timeseries"`
`147`	`147`	`},`
`148`	`148`	`{`