generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 158
Open
Labels
area/tideIssues or PRs related to prow's tide componentIssues or PRs related to prow's tide componentkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Description
What happened:
For a Github PR that has passed all checks but has the Change requested state, Tide repeatedly attempts to MERGE but fails (presumably rejected by Github due to the Change requested state).
What you expected to happen:
I would expect Prow/Tide to be aware of the Change requested state and that it is blocking - and therefore not try to perform MERGE.
How to reproduce it (as minimally and precisely as possible):
- Create a pull request
- Request changes on the PR
- Pass all other checks (e.g. presubmits, lgtm, approve, etc)
- Observe that Tide repeatedly attempts to perform MERGE and fails
Please provide links to example occurrences, if any:
Here is an example PR and tide history:
- test: Fix cleanup for TestSyncFailureAfterSuccessfulSyncs GoogleContainerTools/config-sync#210
- https://oss.gprow.dev/tide-history?repo=GoogleContainerTools%2Fkpt-config-sync&branch=main&pull=210
Anything else we need to know?:
N/A
Copied over from kubernetes/test-infra#27750
Metadata
Metadata
Assignees
Labels
area/tideIssues or PRs related to prow's tide componentIssues or PRs related to prow's tide componentkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.