Skip to content

Commit 10f98da

Browse files
authored
Merge pull request #7972 from goto-opensource/fix/cluster-autoscaler-chart-remove-aws-region-default
fix: remove default value for `awsRegion` value in cluster-autoscaler Helm chart to avoid accidental misconfigurations
2 parents 27d00f4 + 1687d46 commit 10f98da

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

charts/cluster-autoscaler/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ name: cluster-autoscaler
1111
sources:
1212
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
1313
type: application
14-
version: 9.46.3
14+
version: 9.46.4

charts/cluster-autoscaler/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ vpa:
428428
| autoscalingGroups | list | `[]` | For AWS, Azure AKS, Exoscale or Magnum. At least one element is required if not using `autoDiscovery`. For example: <pre> - name: asg1<br /> maxSize: 2<br /> minSize: 1 </pre> For Hetzner Cloud, the `instanceType` and `region` keys are also required. <pre> - name: mypool<br /> maxSize: 2<br /> minSize: 1<br /> instanceType: CPX21<br /> region: FSN1 </pre> |
429429
| autoscalingGroupsnamePrefix | list | `[]` | For GCE. At least one element is required if not using `autoDiscovery`. For example: <pre> - name: ig01<br /> maxSize: 10<br /> minSize: 0 </pre> |
430430
| awsAccessKeyID | string | `""` | AWS access key ID ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)) |
431-
| awsRegion | string | `"us-east-1"` | AWS region (required if `cloudProvider=aws`) |
431+
| awsRegion | string | `""` | AWS region (required if `cloudProvider=aws`) |
432432
| awsSecretAccessKey | string | `""` | AWS access secret key ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)) |
433433
| azureClientID | string | `""` | Service Principal ClientID with contributor permission to Cluster and Node ResourceGroup. Required if `cloudProvider=azure` |
434434
| azureClientSecret | string | `""` | Service Principal ClientSecret with contributor permission to Cluster and Node ResourceGroup. Required if `cloudProvider=azure` |

charts/cluster-autoscaler/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ autoscalingGroupsnamePrefix: []
7373
awsAccessKeyID: ""
7474

7575
# awsRegion -- AWS region (required if `cloudProvider=aws`)
76-
awsRegion: us-east-1
76+
awsRegion: ""
7777

7878
# awsSecretAccessKey -- AWS access secret key ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials))
7979
awsSecretAccessKey: ""

0 commit comments

Comments
 (0)