Skip to content

Commit 3dc60e2

Browse files
committed
test: Speed up iso test with --no-kubernetes
We don't need to start kubernetes for testing the ISO. On macOS the test is 2.45 times faster (from 17.137 seconds to 6.974 seconds). Before: % go test -v ./test/integration -run TestISO -tags integration -count 1 ... --- PASS: TestISOImage (16.27s) --- PASS: TestISOImage/Setup (15.76s) --- PASS: TestISOImage/Binaries (0.00s) --- PASS: TestISOImage/Binaries/crictl (0.08s) --- PASS: TestISOImage/Binaries/podman (0.09s) --- PASS: TestISOImage/Binaries/rsync (0.11s) --- PASS: TestISOImage/Binaries/docker (0.11s) --- PASS: TestISOImage/Binaries/iptables (0.11s) --- PASS: TestISOImage/Binaries/git (0.12s) --- PASS: TestISOImage/Binaries/socat (0.08s) --- PASS: TestISOImage/Binaries/curl (0.08s) --- PASS: TestISOImage/Binaries/wget (0.08s) --- PASS: TestISOImage/PersistentMounts (0.00s) --- PASS: TestISOImage/PersistentMounts//var/lib/toolbox (0.08s) --- PASS: TestISOImage/PersistentMounts//var/lib/boot2docker (0.09s) --- PASS: TestISOImage/PersistentMounts//var/lib/cni (0.09s) --- PASS: TestISOImage/PersistentMounts//data (0.10s) --- PASS: TestISOImage/PersistentMounts//var/lib/kubelet (0.10s) --- PASS: TestISOImage/PersistentMounts//var/lib/minikube (0.11s) --- PASS: TestISOImage/PersistentMounts//var/lib/docker (0.07s) PASS Tests completed in 16.268875292s (result code 0) ok k8s.io/minikube/test/integration 17.137s After: % go test -v ./test/integration -run TestISO -tags integration -count 1 ... --- PASS: TestISOImage (5.77s) --- PASS: TestISOImage/Setup (5.30s) --- PASS: TestISOImage/Binaries (0.00s) --- PASS: TestISOImage/Binaries/wget (0.09s) --- PASS: TestISOImage/Binaries/socat (0.09s) --- PASS: TestISOImage/Binaries/iptables (0.10s) --- PASS: TestISOImage/Binaries/podman (0.10s) --- PASS: TestISOImage/Binaries/crictl (0.11s) --- PASS: TestISOImage/Binaries/git (0.11s) --- PASS: TestISOImage/Binaries/rsync (0.07s) --- PASS: TestISOImage/Binaries/docker (0.08s) --- PASS: TestISOImage/Binaries/curl (0.08s) --- PASS: TestISOImage/PersistentMounts (0.00s) --- PASS: TestISOImage/PersistentMounts//var/lib/toolbox (0.08s) --- PASS: TestISOImage/PersistentMounts//var/lib/boot2docker (0.09s) --- PASS: TestISOImage/PersistentMounts//var/lib/cni (0.09s) --- PASS: TestISOImage/PersistentMounts//var/lib/minikube (0.10s) --- PASS: TestISOImage/PersistentMounts//data (0.10s) --- PASS: TestISOImage/PersistentMounts//var/lib/docker (0.11s) --- PASS: TestISOImage/PersistentMounts//var/lib/kubelet (0.07s) PASS Tests completed in 5.7657725s (result code 0) ok k8s.io/minikube/test/integration 6.974s
1 parent 5bd82cb commit 3dc60e2

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

test/integration/iso_test.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"fmt"
2424
"os/exec"
2525
"runtime"
26-
"strings"
2726
"testing"
2827

2928
"k8s.io/minikube/pkg/minikube/vmpath"
@@ -42,15 +41,11 @@ func TestISOImage(t *testing.T) {
4241
defer CleanupWithLogs(t, profile, cancel)
4342

4443
t.Run("Setup", func(t *testing.T) {
45-
args := append([]string{"start", "-p", profile, "--install-addons=false", "--memory=3072", "--wait=false", "--disable-metrics=true"}, StartArgs()...)
44+
args := append([]string{"start", "-p", profile, "--no-kubernetes"}, StartArgs()...)
4645
rr, err := Run(t, exec.CommandContext(ctx, Target(), args...))
4746
if err != nil {
4847
t.Errorf("failed to start minikube: args %q: %v", rr.Command(), err)
4948
}
50-
51-
if strings.Contains(rr.Stderr.String(), "kubelet.housekeeping-interval=5m") {
52-
t.Error("--disable-metrics=true is not working, housekeeping interval not increased")
53-
}
5449
})
5550

5651
// Run as a group so that our defer doesn't happen as tests are runnings

0 commit comments

Comments
 (0)