-
Notifications
You must be signed in to change notification settings - Fork 5.1k
build: Update go from 1.24.6 to 1.25.3 #21884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: Update go from 1.24.6 to 1.25.3 #21884
Conversation
|
ok-to-build-image |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: minikube-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @minikube-bot. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
as bumping go usually requires bumping golangci-lint as well (or latter might complain about being compiled with an older version of go than the one code, that it is supposed to run linters against, is using), i added a commit that bumps golangci-lint to v2.1.6, and also silenced some revive linter complaints, as i think those should be addressed in a separate pr the other commit was to address next complaint the 'Verify go mod tidy' step had local minikube binary building & testingkvm driverdocker driver |
|
/ok-to-test |
|
@minikube-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
thank you @prezha lets see if the image builds now |
|
ok-to-build-image |
Kubernetes Project just updated the golang version, updating minikube golang to match Kubernetes.
This PR was auto-generated by
make update-golang-versionusing update-golang-version.yml CI Workflow.