-
Notifications
You must be signed in to change notification settings - Fork 23
ci: run e2e tests on macOS and Windows #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- e2e job uses OS matrix: ubuntu-latest, macos-latest, windows-latest - Use cargo test --test "*" for cross-platform instead of make - Windows setup: enable git long paths; set CMAKE_POLICY_VERSION_MINIMUM=3.5 for aws-lc-sys - tests: gate Docker/testcontainers tests (airgap, push) to Linux and add no-op stubs elsewhere Signed-off-by: Rishi Jat <[email protected]>
ff714c4 to
b666dfb
Compare
|
@flavio please review when you get a chance.Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 34 34
Lines 4947 4947
=======================================
Hits 4329 4329
Misses 618 618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flavio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good to me, I also like the approach you used to handle the test containers dependency on windows and mac.
However, the e2e test are currently failing on these platforms (or are not run). Can you look into that?
Signed-off-by: Rishi Jat <[email protected]>
|
The current change seems to not be enough, can you have a look please? |
|
sorry, for late will fix the ci errors soon. |
Summay
Fixes #1189