Skip to content

Conversation

@rishi-jat
Copy link

@rishi-jat rishi-jat commented Sep 4, 2025

Summay

  • Expand e2e CI to matrix: ubuntu, macOS, Windows
  • Use cargo test --test "*" for cross‑platform runs
  • Gate Docker/testcontainers tests to Linux; add no-op stubs on other OSes
  • Windows: enable git long paths and set CMAKE_POLICY_VERSION_MINIMUM=3.5

Fixes #1189

@rishi-jat rishi-jat requested a review from a team as a code owner September 4, 2025 10:28
@github-project-automation github-project-automation bot moved this to Pending review in Kubewarden Sep 4, 2025
- e2e job uses OS matrix: ubuntu-latest, macos-latest, windows-latest
- Use cargo test --test "*" for cross-platform instead of make
- Windows setup: enable git long paths; set CMAKE_POLICY_VERSION_MINIMUM=3.5 for aws-lc-sys
- tests: gate Docker/testcontainers tests (airgap, push) to Linux and add no-op stubs elsewhere

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Copy link
Author

@flavio please review when you get a chance.Thanks!

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (b293ac3) to head (6ff3c32).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1351   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files          34       34           
  Lines        4947     4947           
=======================================
  Hits         4329     4329           
  Misses        618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me, I also like the approach you used to handle the test containers dependency on windows and mac.

However, the e2e test are currently failing on these platforms (or are not run). Can you look into that?

@flavio flavio moved this from Pending review to In Progress in Kubewarden Sep 5, 2025
@rishi-jat rishi-jat requested a review from flavio September 7, 2025 22:37
@viccuad
Copy link
Member

viccuad commented Sep 8, 2025

The current change seems to not be enough, can you have a look please?
https://github.com/kubewarden/kwctl/actions/runs/17533714097/job/49823266040?pr=1351#step:6:1409

@rishi-jat
Copy link
Author

sorry, for late will fix the ci errors soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Feature Request: run integration tests on OSX and windows

3 participants