Add Support for PHP 8.4 and allow installation with symfony/di@^7
#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalheidmann
force-pushed
the
8.4-support
branch
3 times, most recently
from
a83ffcb to
0963807
Compare
Signed-off-by: pascal.heidmann <[email protected]>
pascalheidmann
force-pushed
the
8.4-support
branch
from
0963807 to
a9bc367
Compare
gsteel
requested changes
Jun 11, 2025
…f ignoring psalm warnings Signed-off-by: pascal.heidmann <[email protected]>
samsonasik
reviewed
Jun 11, 2025
Author
|
@froschdesign @gsteel thank you for your feedback! |
gsteel
approved these changes
Jun 11, 2025
Member
gsteel
left a comment
gsteel
left a comment
There was a problem hiding this comment.
Thanks very much @pascalheidmann 👍
gsteel
changed the title
symfony/di@^7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow installing the library on every php 8.x version to make future updates easier/not necessary. Also support for newer symfony DI baked in.
I had to disable
failOnDeprecationin phpunit due to incompatibilities in the phpunit executable itself, sadly.