Skip to content

fix(core): implement ChatPromptTemplate.save() method (#32637) #33631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(core): implement ChatPromptTemplate.save() method (#32637) #33631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e00f3ff
fix(core): implement ChatPromptTemplate.save() method (#32637)
Oct 21, 2025
f6fad1a
Merge branch 'master' into fix-chat-prompt-template-save-32637
ccurme Nov 7, 2025
c637b70
add failing test
ccurme Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions libs/core/langchain_core/prompts/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,14 +1281,6 @@ def _prompt_type(self) -> str:
"""Name of prompt type. Used for serialization."""
return "chat"

def save(self, file_path: Path | str) -> None:
"""Save prompt to file.

Args:
file_path: path to file.
"""
raise NotImplementedError

@override
def pretty_repr(self, html: bool = False) -> str:
"""Human-readable representation.
Expand Down
11 changes: 11 additions & 0 deletions libs/core/tests/unit_tests/prompts/test_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import pytest

from langchain_core.prompts import ChatPromptTemplate
from langchain_core.prompts.few_shot import FewShotPromptTemplate
from langchain_core.prompts.loading import load_prompt
from langchain_core.prompts.prompt import PromptTemplate
Expand Down Expand Up @@ -87,6 +88,16 @@ def test_saving_loading_round_trip(tmp_path: Path) -> None:
loaded_prompt = load_prompt(tmp_path / "few_shot.yaml")
assert loaded_prompt == few_shot_prompt

chat_prompt = ChatPromptTemplate(
[
{"role": "system", "content": "{foo} foo"},
{"role": "user", "content": "{bar} bar"},
]
)
chat_prompt.save(file_path=tmp_path / "chat_prompt.yaml")
loaded_prompt = load_prompt(tmp_path / "chat_prompt.yaml")
assert loaded_prompt == chat_prompt


def test_loading_with_template_as_file() -> None:
"""Test loading when the template is a file."""
Expand Down
Loading