surface: Don't check if props!=0 before calling SDL_HasProperty on it.

icculus · icculus · commit b0e161ffdf4e · 2025-12-07T21:14:29.000-05:00
diff --git a/src/video/SDL_surface.c b/src/video/SDL_surface.c
@@ -2200,7 +2200,7 @@ SDL_Surface *SDL_RotateSurface(SDL_Surface *surface, float angle)
     }
 
     if (rotated) {
-        if (surface->props && SDL_HasProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT)) {
+        if (SDL_HasProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT)) {
             const float rotation = (SDL_GetNumberProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT, 0) - angle);
             SDL_SetFloatProperty(SDL_GetSurfaceProperties(rotated), SDL_PROP_SURFACE_ROTATION_FLOAT, rotation);
         }

Original file line number	Diff line number	Diff line change
`@@ -2200,7 +2200,7 @@ SDL_Surface SDL_RotateSurface(SDL_Surface surface, float angle)`
`2200`	`2200`	`}`
`2201`	`2201`
`2202`	`2202`	`if (rotated) {`
`2203`		`- if (surface->props && SDL_HasProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT)) {`
	`2203`	`+ if (SDL_HasProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT)) {`
`2204`	`2204`	`const float rotation = (SDL_GetNumberProperty(surface->props, SDL_PROP_SURFACE_ROTATION_FLOAT, 0) - angle);`
`2205`	`2205`	`SDL_SetFloatProperty(SDL_GetSurfaceProperties(rotated), SDL_PROP_SURFACE_ROTATION_FLOAT, rotation);`
`2206`	`2206`	`}`