Merge pull request #324 from lidofinance/feature/orc-526-fix-bug-in-depositor-metrics

feat: export gas metrics in basic checks

Author: F4ever

src/bots/depositor.py

@@ -267,6 +267,9 @@ def _get_preferred_to_deposit_modules(self) -> list[int]:
         # gather quorum
         now = datetime.now()
         for module_id in module_ids:
+            # Just for metrics
+            self._select_strategy(module_id).is_gas_price_ok(module_id)
+
             if self._get_quorum(module_id):
                 self._module_last_heart_beat[module_id] = now
 
@@ -284,6 +287,7 @@ def _get_preferred_to_deposit_modules(self) -> list[int]:
         # take all the modules in sorted order until the first healthy one(including)
         result = self._take_until_first_healthy_module(modules_healthiness)
         logger.info({'msg': f'Module iteration order {result}.'})
+
         return result
 
     def _is_module_healthy(self, module_id: int) -> bool:

tests/bots/test_depositor.py

@@ -48,6 +48,7 @@ def test_get_preferred_to_deposit_modules(self, mock_datetime):
             [0, 0, [3], [10, 16]],  # Module 3: 6 active validators
         ]
         self.bot._get_quorum = Mock()
+        self.bot._select_strategy = Mock()
 
         # Mock module healthiness and quorum
         # Module ID:                                          2      1      3
@@ -171,6 +172,7 @@ def test_depositor_one_module_deposited(depositor_bot, block_data):
             (0, 0, (2,), (0, 10, 10)),
         ]
     )
+    depositor_bot._general_strategy.is_gas_price_ok = Mock(return_value=True)
     depositor_bot._general_strategy.deposited_keys_amount = Mock(return_value=10)
     depositor_bot._check_balance = Mock()
     depositor_bot._deposit_to_module = Mock(return_value=True)