Skip to content

Commit 555583d

Browse files
nirsnirs
committed
ci: Split to multiple workflows
- build: build on multiple version of macOS - lima: lima integration tests - qemu: lima integration tests - release: already exist Try to run integration tests on all platforms to see what works now. We probably want to minimize the number of platform since the macOS runners are very flaky. The lima workflow is flaky. Sometimes all 3 platforms succeed, but usually one gets stuck and cancelled after many minutes. Notes: - Workflow names unified to Title case. This is more consistent with github UI and standard workflow names. Workarounds: - on macos-15-large brew is not updated and get lima 0.23.2. Fixed by running brew update. Signed-off-by: Nir Soffer <[email protected]>
1 parent 6235461 commit 555583d

File tree

3 files changed

+103
-27
lines changed

3 files changed

+103
-27
lines changed

‎.github/workflows/build.yaml‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
name: Build
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
- 'release/**'
8+
pull_request:
9+
10+
permissions:
11+
contents: read
12+
13+
jobs:
14+
build:
15+
name: Build on multiple version of macOS
16+
strategy:
17+
fail-fast: false
18+
matrix:
19+
platform:
20+
- macos-13
21+
- macos-14
22+
- macos-15
23+
runs-on: ${{ matrix.platform }}
24+
timeout-minutes: 10
25+
steps:
26+
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
27+
with:
28+
fetch-depth: 1
29+
- name: Build
30+
run: make

.github/workflows/test.yaml renamed to .github/workflows/lima.yaml

Lines changed: 16 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: test
1+
name: Lima
22

33
on:
44
push:
@@ -12,7 +12,7 @@ permissions:
1212

1313
jobs:
1414
integration:
15-
name: Integration tests
15+
name: Lima integration tests
1616
strategy:
1717
fail-fast: false
1818
matrix:
@@ -22,8 +22,11 @@ jobs:
2222
platform:
2323
- macos-13-large
2424
- macos-14-large
25+
- macos-15-large
2526
runs-on: ${{ matrix.platform }}
26-
timeout-minutes: 40
27+
# Typically takes 8 minutes. If a step get stuck for many mintues it is
28+
# unlikely to succeed.
29+
timeout-minutes: 20
2730
steps:
2831
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
2932
with:
@@ -36,43 +39,29 @@ jobs:
3639
- name: Make Install (x86_64)
3740
run: |
3841
# compile for x86_64
39-
sudo make PREFIX=/opt/socket_vmnet install
42+
make
43+
# Skip installing launchd services
44+
sudo make install.bin install.doc
4045
if file /opt/socket_vmnet/bin/* | grep -q arm64 ; then false ; fi
4146
- name: Cleanup
4247
run: |
43-
sudo make clean
48+
make clean
4449
- name: Make Install (arm64)
4550
run: |
4651
# cross-compile for arm64
4752
# Skip installing launchd services
48-
sudo make PREFIX=/opt/socket_vmnet.arm64 ARCH=arm64 install.bin install.doc
53+
make ARCH=arm64
54+
sudo make PREFIX=/opt/socket_vmnet.arm64 install.bin install.doc
4955
if file /opt/socket_vmnet.arm64/bin/* | grep -q x86_64 ; then false ; fi
50-
- name: Print launchd status (shared mode)
51-
run: launchctl print system/io.github.lima-vm.socket_vmnet
52-
- name: Fetch homebrew-core commit messages
53-
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
54-
with:
55-
# needed by ./hack/brew-install-version.sh
56-
repository: homebrew/homebrew-core
57-
path: homebrew-core
58-
fetch-depth: 0
59-
filter: tree:0
60-
- name: Install test dependencies
61-
run: |
62-
brew install bash coreutils
63-
# QEMU 9.1.0 seems to break on GitHub runners, both on Monterey and Ventura
64-
# We revert back to 8.2.1, which seems to work fine
65-
./hack/brew-install-version.sh qemu 8.2.1
66-
- name: Test (shared mode)
67-
run: ./test/test.sh /var/run/socket_vmnet
68-
# Bridged mode cannot be tested on GHA
56+
- name: Update brew (macos-15-large)
57+
if: matrix.platform == 'macos-15-large'
58+
# Without this we get lima 0.23.2 instead of latest release.
59+
run: brew update
6960
- name: Install Lima
7061
run: |
7162
brew install lima
7263
limactl sudoers >etc_sudoers.d_lima
7364
sudo install -o root etc_sudoers.d_lima "/private/etc/sudoers.d/lima"
74-
- name: Install the dependencies for the Lima integration test
75-
run: brew install iperf3 jq
7665
- name: "Lima: vm1: prepare"
7766
run: |
7867
limactl start --name=vm1 --tty=false ./test/vmnet.yaml

‎.github/workflows/qemu.yaml‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
name: QEMU
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
- 'release/**'
8+
pull_request:
9+
10+
permissions:
11+
contents: read
12+
13+
jobs:
14+
integration:
15+
name: QEMU integration tests
16+
strategy:
17+
fail-fast: false
18+
matrix:
19+
# We run on standard arm64 runners since this test is very quick.
20+
platform:
21+
- macos-13
22+
- macos-14
23+
- macos-15
24+
runs-on: ${{ matrix.platform }}
25+
timeout-minutes: 10
26+
steps:
27+
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
28+
with:
29+
fetch-depth: 1
30+
- name: Show host info
31+
run: |
32+
uname -a
33+
sw_vers
34+
ifconfig
35+
- name: Build
36+
run: |
37+
make
38+
sudo make install
39+
- name: Print launchd status (shared mode)
40+
run: launchctl print system/io.github.lima-vm.socket_vmnet
41+
- name: Fetch homebrew-core commit messages
42+
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
43+
with:
44+
# needed by ./hack/brew-install-version.sh
45+
repository: homebrew/homebrew-core
46+
path: homebrew-core
47+
fetch-depth: 0
48+
filter: tree:0
49+
- name: Install test dependencies
50+
run: |
51+
brew install bash coreutils
52+
# QEMU 9.1.0 seems to break on GitHub runners, both on Monterey and Ventura
53+
# We revert back to 8.2.1, which seems to work fine
54+
./hack/brew-install-version.sh qemu 8.2.1
55+
- name: Test (shared mode)
56+
run: ./test/test.sh /var/run/socket_vmnet
57+
# Bridged mode cannot be tested on GHA

0 commit comments

Comments
 (0)