From d43a09cffe7840345e1f68c863f9e3cc6032ebbd Mon Sep 17 00:00:00 2001 From: Suhail Kakar Date: Thu, 30 May 2024 16:06:19 +0530 Subject: [PATCH 1/2] ui: fix june track on sidebar --- packages/www/components/Sidebar/index.tsx | 21 +++++++++++++-------- packages/www/package.json | 1 + 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/packages/www/components/Sidebar/index.tsx b/packages/www/components/Sidebar/index.tsx index bd28fcf46d..d9011499c0 100644 --- a/packages/www/components/Sidebar/index.tsx +++ b/packages/www/components/Sidebar/index.tsx @@ -80,16 +80,21 @@ const Sidebar = ({ id }: { id: SidebarId }) => { const June = useJune(); useEffect(() => { - const handleRouteChange = (url, { shallow }) => { - if (June) June.page(url); - }; + if (typeof June !== "undefined") { + const handleRouteChange = (url, { shallow }) => { + console.log("Tracking URL:", url); + June.track(url); + }; - router.events.on("routeChangeStart", handleRouteChange); + console.log("Adding event listener"); + router.events.on("routeChangeStart", handleRouteChange); - return () => { - router.events.off("routeChangeStart", handleRouteChange); - }; - }, [June]); + return () => { + console.log("Removing event listener"); + router.events.off("routeChangeStart", handleRouteChange); + }; + } + }, [June, router.events]); return ( Date: Thu, 30 May 2024 16:27:30 +0530 Subject: [PATCH 2/2] Update StreamHealthTab.tsx --- packages/www/components/StreamDetails/StreamHealthTab.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/www/components/StreamDetails/StreamHealthTab.tsx b/packages/www/components/StreamDetails/StreamHealthTab.tsx index b0e46ac16a..e89ca9ef52 100644 --- a/packages/www/components/StreamDetails/StreamHealthTab.tsx +++ b/packages/www/components/StreamDetails/StreamHealthTab.tsx @@ -26,7 +26,6 @@ const StreamHealthTab = ({ stream, streamHealth, invalidateStream }) => { { name: 0, "Session bitrate": 0 }, ]); - const June = useJune(); const [multiDataChart, setMultiDataChart] = useState( [] ); @@ -35,8 +34,6 @@ const StreamHealthTab = ({ stream, streamHealth, invalidateStream }) => { const [info, setInfo] = useState(null); - June?.track(events.stream.health); - const { getStreamInfo } = useApi(); const { query } = router;