[Torch] Canonicalize pool ops with single int tuple params. #4250
+304
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjarus
approved these changes
Jul 2, 2025
vivekkhandelwal1
previously requested changes
Jul 9, 2025
Member
Author
|
Hi @vivekkhandelwal1 do you have any further comments on this? Since this has been open for a while, I'll go ahead with merging the PR if I don't hear back from you by this week. I'll be happy to address any further comments afterwards as well. Thanks! |
sahas3
dismissed
vivekkhandelwal1’s stale review
Dismissing the review to merge this change since I have not received any feedback after addressing the comments made earlier and the PR has been open for a long time as mentioned in #4250 (comment). I'll be happy to make any necessary changes if I receive new feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3885 by repeating the single int to match with expected spatial dims.