Merge pull request #179 from lob/gh-actions

Github action for running tests.

Author: Shariq Torres

.coveragerc

@@ -1,3 +1,5 @@
+[run]
+source=lob
 [report]
 exclude_lines =
   # Have to re-enable the standard pragma

.github/workflows/build.yaml

@@ -0,0 +1,23 @@
+name: Pipenv Coveralls Test
+
+on: ["push", "pull_request"]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [ '3.10', '3.9', '3.8', '3.7', '3.6' ]
+    name: Python ${{ matrix.python-version }} sample
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+          cache: 'pipenv'
+      - run: pip install pipenv
+      - run: pipenv sync --dev
+      - run: pipenv run tests
+        env:
+          LOB_API_KEY: ${{ secrets.LOB_API_KEY }}

.travis.yml

@@ -8,14 +8,15 @@ requests = "*"
 
 [dev-packages]
 "flake8" = "*"
-coverage = "*"
-coveralls = "*"
+coverage = ">=5.5"
+coveralls = ">=2.2.0"
 bumpversion = "*"
 setuptools = "*"
 twine = "*"
-pytest = "*"
-pytest-cov = "*"
+pytest = ">=6.2.1"
+pytest-cov = ">=2.11.1"
 
 [scripts]
 # these commands can be invoked with `pipenv run <script_name>`
-tests = "pytest --cov=lob"
+tests = "pytest --cov"
+coveralls = "coveralls --service=github.com"

Pipfile

@@ -1,12 +1,28 @@
 import unittest
 import os
 import lob
+import pytest
 
 
 class TestAddressFunctions(unittest.TestCase):
     def setUp(self):
         lob.api_key = os.environ.get('LOB_API_KEY')
 
+
+    def test_create_address(self):
+        address = lob.Address.create(
+            name='Lob',
+            address_line1='185 Berry Street',
+            address_line2='Suite 1510',
+            address_city='San Francisco',
+            address_zip='94017',
+            address_state='CA',
+            address_country='US'
+        )
+
+        self.assertTrue(isinstance(address, lob.Address))
+        self.assertEqual(address.name, 'LOB')
+
     def test_list_addresses(self):
         addresses = lob.Address.list()
         self.assertTrue(isinstance(addresses.data[0], lob.Address))
@@ -24,21 +40,8 @@ def test_list_addresses_limit(self):
         self.assertEqual(len(addresses.data), 2)
 
     def test_list_address_fail(self):
-        self.assertRaises(lob.error.InvalidRequestError, lob.Address.list, limit=1000)
-
-    def test_create_address(self):
-        address = lob.Address.create(
-            name='Lob',
-            address_line1='185 Berry Street',
-            address_line2='Suite 1510',
-            address_city='San Francisco',
-            address_zip='94017',
-            address_state='CA',
-            address_country='US'
-        )
-
-        self.assertTrue(isinstance(address, lob.Address))
-        self.assertEqual(address.name, 'LOB')
+        with pytest.raises(lob.error.InvalidRequestError):
+            lob.Address.list(foobar=1000)
 
     def test_create_addresss_fail(self):
         self.assertRaises(lob.error.InvalidRequestError, lob.Address.create)
@@ -51,6 +54,15 @@ def test_retrieve_address_fail(self):
         self.assertRaises(lob.error.InvalidRequestError, lob.Address.retrieve, id='test')
 
     def test_delete_address(self):
-        addr = lob.Address.list().data[0].id
-        delAddr = lob.Address.delete(id=addr)
-        self.assertEqual(addr, delAddr.id)
+        address = lob.Address.create(
+            name='Lob',
+            address_line1='185 Berry Street',
+            address_line2='Suite 1510',
+            address_city='San Francisco',
+            address_zip='94017',
+            address_state='CA',
+            address_country='US'
+        )
+        
+        delAddr = lob.Address.delete(id=address.id)
+        self.assertEqual(address.id, delAddr.id)

tests/test_address.py

@@ -1,6 +1,7 @@
 import unittest
 import os
 import lob
+import pytest
 
 
 class BankAccountFunctions(unittest.TestCase):
@@ -19,7 +20,9 @@ def test_list_bankAccounts_limit(self):
         self.assertEqual(len(bankAccounts.data), 2)
 
     def test_list_bankAccounts_fail(self):
-        self.assertRaises(lob.error.InvalidRequestError, lob.BankAccount.list, limit=1000)
+        with pytest.raises(lob.error.InvalidRequestError):
+            lob.BankAccount.list(foobar=1000)
+        # self.assertRaises(lob.error.InvalidRequestError, lob.BankAccount.list, limit=1000)
 
     def test_create_bankAccount_fail(self):
         self.assertRaises(lob.error.InvalidRequestError, lob.BankAccount.create)

tests/test_bankaccount.py

@@ -1,7 +1,7 @@
 import lob
 import os
 import unittest
-
+import pytest
 
 class CheckFunctions(unittest.TestCase):
     def setUp(self):
@@ -26,7 +26,8 @@ def test_list_checks_limit(self):
         self.assertEqual(len(checks.data), 2)
 
     def test_list_checks_fail(self):
-        self.assertRaises(lob.error.InvalidRequestError, lob.Check.list, limit=1000)
+        with pytest.raises(lob.error.InvalidRequestError):
+            lob.Check.list(foobar=1000)
 
     def test_create_check(self):
         check = lob.Check.create(

tests/test_check.py

@@ -1,7 +1,7 @@
 import unittest
 import os
 import lob
-
+import pytest
 
 class PostcardFunctions(unittest.TestCase):
     def setUp(self):
@@ -19,12 +19,23 @@ def test_list_postcards_limit(self):
         self.assertEqual(len(postcards.data), 2)
 
     def test_list_postcards_metadata(self):
+        postcard = lob.Postcard.create(
+            to_address=self.addr.id,
+            from_address=self.addr.id,
+            front='<h1>{{front_name}}</h1>',
+            back='<h1>{{back_name}}</h1>',
+            merge_variables={
+                'front_name': 'Peter',
+                'back_name': 'Otto'
+            },
+            metadata={'campagin': 'LOB2015'}
+        )
         postcards = lob.Postcard.list(metadata={'campagin': 'LOB2015'})
         self.assertTrue(isinstance(postcards.data[0], lob.Postcard))
-        self.assertEqual(len(postcards.data), 1)
 
     def test_list_postcards_fail(self):
-        self.assertRaises(lob.error.InvalidRequestError, lob.Postcard.list, limit=1000)
+        with pytest.raises(lob.error.InvalidRequestError):
+            lob.Postcard.list(foobar=1000)
 
     def test_create_postcard(self):
         postcard = lob.Postcard.create(

tests/test_postcard.py

@@ -1,7 +1,7 @@
 import unittest
 import os
 import lob
-
+import pytest
 
 class SelfMailerFunctions(unittest.TestCase):
     def setUp(self):
@@ -24,7 +24,8 @@ def test_list_self_mailers_metadata(self):
         self.assertTrue(len(self_mailers.data) > 0)
 
     def test_list_self_mailers_fail(self):
-        self.assertRaises(lob.error.InvalidRequestError, lob.SelfMailer.list, limit=1000)
+        with pytest.raises(lob.error.InvalidRequestError):
+            lob.SelfMailer.list(foobar=333)
 
     def test_create_self_mailer(self):
         self_mailer = lob.SelfMailer.create(