Skip to content

Conversation

@alirezaImani79
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

I have added a useDirection hook to provide app direction using Antd direction config .

We will choose Icons direction using useDirection hook .

@vercel
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lobe-ui ✅ Ready (Inspect) Visit Preview Mar 21, 2025 8:20am

@lobehubbot
Copy link
Member

👍 @alirezaImani-f4L3e


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 1.54%. Comparing base (5851677) to head (bdd17cf).
Report is 347 commits behind head on master.

Files with missing lines Patch % Lines
src/hooks/useDirection.ts 0.00% 7 Missing and 1 partial ⚠️
...DraggablePanel/components/DraggablePanelHeader.tsx 0.00% 3 Missing and 1 partial ⚠️
src/EmojiPicker/AvatarUploader.tsx 0.00% 4 Missing ⚠️
src/Form/demos/StateControl.tsx 0.00% 4 Missing ⚠️
src/Highlighter/FullFeatured.tsx 0.00% 4 Missing ⚠️
...Plugins/MarkdownElements/AntThinking/Component.tsx 0.00% 4 Missing ⚠️
src/Mermaid/FullFeatured.tsx 0.00% 3 Missing and 1 partial ⚠️
src/chat/ChatHeader/index.tsx 0.00% 4 Missing ⚠️
src/mobile/MobileNavBar/index.tsx 0.00% 4 Missing ⚠️
src/Alert/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #262      +/-   ##
=========================================
+ Coverage    0.00%   1.54%   +1.54%     
=========================================
  Files         330     490     +160     
  Lines       22325   18046    -4279     
  Branches      330     513     +183     
=========================================
+ Hits            0     278     +278     
+ Misses      21995   17478    -4517     
+ Partials      330     290      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx
Copy link
Member

arvinxx commented Feb 14, 2025

I think a better way is to add an internal rtl control in the ActionIcon and Icon Component

@alirezaImani79
Copy link
Contributor Author

I think it shouldn’t be managed in ActionIcon because it’s dependent on the icon being used, but ActionIcon shouldn’t be aware of the Icon content.

@alirezaImani79
Copy link
Contributor Author

alirezaImani79 commented Feb 25, 2025

is there a problem with pr ? if you would not merge it , please fix this problem .

@canisminor1990 canisminor1990 force-pushed the fix/directional-icons-adoption-with-rtl-langs branch from 91110db to bdd17cf Compare March 21, 2025 07:56
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 21, 2025

Open in Stackblitz

npm i https://pkg.pr.new/lobehub/lobe-ui/@lobehub/ui@262

commit: bdd17cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants