Fix warnings from clippy

Author: gwennlbh

lychee-bin/src/commands/check.rs

@@ -203,9 +203,9 @@ async fn response_receive_task(
     formatter: Box<dyn ResponseFormatter>,
     mut stats: ResponseStats,
 ) -> Result<(Option<ProgressBar>, ResponseStats)> {
-    let mut i = 0;
+    // let mut i = 0;
     while let Some(response) = recv_resp.recv().await {
-        i = i + 1;
+        // i += 1;
         // println!(
         //     "starting response #{} out of {}",
         //     i,
@@ -219,7 +219,7 @@ async fn response_receive_task(
             &verbose,
         )?;
 
-        for uri in response.body().subsequent_uris.iter() {
+        for uri in &response.body().subsequent_uris {
             let request = Request::try_from(uri.clone())?;
             req_send
                 .send(Ok(request))
@@ -235,7 +235,7 @@ async fn response_receive_task(
         remaining_requests.fetch_sub(1, Ordering::Relaxed);
         let remaining_now = remaining_requests.load(Ordering::Relaxed);
         // println!("remaining requests: {}", remaining_now);
-        if remaining_now <= 0 {
+        if remaining_now == 0 {
             break;
         }
 

lychee-lib/src/checker/website.rs

@@ -140,7 +140,7 @@ impl WebsiteChecker {
                             .collect();
                         // println!("recursing {}: found {:?}", response_url, links.clone());
 
-                        return (status, links);
+                        (status, links)
                     }
                 }
             }
@@ -174,13 +174,13 @@ impl WebsiteChecker {
                     .check_website_inner(&uri.to_https()?, &default_chain)
                     .await;
 
-                if !status.is_success() {
+                if status.is_success() {
+                    Ok((Status::Ok(code), new_uris))
+                } else {
                     Ok((
                         Status::Error(ErrorKind::InsecureURL(uri.to_https()?)),
                         vec![],
                     ))
-                } else {
-                    Ok((Status::Ok(code), new_uris))
                 }
             }
             s => Ok(s),

lychee-lib/src/types/basic_auth/credentials.rs

@@ -43,7 +43,8 @@ pub struct BasicAuthCredentials {
 
 impl BasicAuthCredentials {
     /// Create a new [`BasicAuthCredentials`] instance.
-    pub fn new(username: String, password: String) -> Self {
+    #[must_use]
+    pub const fn new(username: String, password: String) -> Self {
         Self {
             username,
             password,
@@ -62,6 +63,7 @@ impl Hash for BasicAuthCredentials {
 impl FromStr for BasicAuthCredentials {
     type Err = BasicAuthCredentialsParseError;
 
+    #[must_use]
     fn from_str(credentials: &str) -> Result<Self, Self::Err> {
         let parts: Vec<_> = credentials.trim().split(':').collect();
 

lychee-lib/src/types/input.rs

@@ -198,6 +198,7 @@ impl Input {
     }
 
     /// Construct a new `Input` source from a raw string that represents the contents of the input (website, file, etc.)
+    #[must_use]
     pub fn raw_string(s: &str, file_type_hint: Option<FileType>) -> Self {
         Self {
             source: InputSource::String(s.to_owned()),