Remove deployment resource because of auto-deploy

Author: tleguijt

src/mach/templates/partials/endpoints/aws_api_gateway.tf

@@ -22,13 +22,11 @@ resource "aws_apigatewayv2_route" "{{ endpoint.key|slugify }}_application" {
   route_key = "$default"
 }
 
-resource "aws_apigatewayv2_deployment" "{{ endpoint.key|slugify }}_default" {
-  api_id      = aws_apigatewayv2_api.{{ endpoint.key|slugify }}_gateway.id
-  description = "Stage for default release"
-
-  lifecycle {
-    create_before_destroy = true
-  }
+resource "aws_apigatewayv2_stage" "{{ endpoint.key|slugify }}_default" {
+  name                  = "$default"
+  description           = "Stage for default release"
+  api_id                = aws_apigatewayv2_api.{{ endpoint.key|slugify }}_gateway.id
+  auto_deploy           = true
 
   depends_on = [
     {% for component in endpoint.components %}
@@ -37,14 +35,6 @@ resource "aws_apigatewayv2_deployment" "{{ endpoint.key|slugify }}_default" {
   ]
 }
 
-resource "aws_apigatewayv2_stage" "{{ endpoint.key|slugify }}_default" {
-  name                  = "$default"
-  description           = "Stage for default release"
-  api_id                = aws_apigatewayv2_api.{{ endpoint.key|slugify }}_gateway.id
-  deployment_id         = aws_apigatewayv2_deployment.{{ endpoint.key|slugify }}_default.id
-  auto_deploy           = true
-}
-
 # Route53 mappings
 resource "aws_apigatewayv2_domain_name" "{{ endpoint.key|slugify }}" {
   domain_name = "{{ endpoint.url }}"

tests/files/aws_config1_expected_mach-site-eu.json

@@ -214,30 +214,6 @@
         }
       }
     },
-    {
-      "aws_apigatewayv2_deployment": {
-        "main_default": {
-          "api_id": [
-            "${aws_apigatewayv2_api.main_gateway.id}"
-          ],
-          "description": [
-            "Stage for default release"
-          ],
-          "lifecycle": [
-            {
-              "create_before_destroy": [
-                true
-              ]
-            }
-          ],
-          "depends_on": [
-            [
-              "${module.payment}"
-            ]
-          ]
-        }
-      }
-    },
     {
       "aws_apigatewayv2_stage": {
         "main_default": {
@@ -250,11 +226,13 @@
           "api_id": [
             "${aws_apigatewayv2_api.main_gateway.id}"
           ],
-          "deployment_id": [
-            "${aws_apigatewayv2_deployment.main_default.id}"
-          ],
           "auto_deploy": [
             true
+          ],
+          "depends_on": [
+            [
+              "${module.payment}"
+            ]
           ]
         }
       }

tests/files/aws_config1_expected_mach-site-us.json

@@ -211,30 +211,6 @@
         }
       }
     },
-    {
-      "aws_apigatewayv2_deployment": {
-        "main_default": {
-          "api_id": [
-            "${aws_apigatewayv2_api.main_gateway.id}"
-          ],
-          "description": [
-            "Stage for default release"
-          ],
-          "lifecycle": [
-            {
-              "create_before_destroy": [
-                true
-              ]
-            }
-          ],
-          "depends_on": [
-            [
-              "${module.payment}"
-            ]
-          ]
-        }
-      }
-    },
     {
       "aws_apigatewayv2_stage": {
         "main_default": {
@@ -247,11 +223,13 @@
           "api_id": [
             "${aws_apigatewayv2_api.main_gateway.id}"
           ],
-          "deployment_id": [
-            "${aws_apigatewayv2_deployment.main_default.id}"
-          ],
           "auto_deploy": [
             true
+          ],
+          "depends_on": [
+            [
+              "${module.payment}"
+            ]
           ]
         }
       }

tests/unittests/test_terraform.py

@@ -109,7 +109,6 @@ def test_generate_w_endpoints(config: types.MachConfig, tf_mock):
         "aws_acm_certificate.public",
         "aws_apigatewayv2_api.public_gateway",
         "aws_apigatewayv2_api_mapping.public",
-        "aws_apigatewayv2_deployment.public_default",
         "aws_apigatewayv2_domain_name.public",
         "aws_apigatewayv2_route.public_application",
         "aws_apigatewayv2_stage.public_default",
@@ -148,8 +147,6 @@ def test_generate_w_endpoints(config: types.MachConfig, tf_mock):
         "aws_apigatewayv2_api.public_gateway",
         "aws_apigatewayv2_api_mapping.private",
         "aws_apigatewayv2_api_mapping.public",
-        "aws_apigatewayv2_deployment.private_default",
-        "aws_apigatewayv2_deployment.public_default",
         "aws_apigatewayv2_domain_name.private",
         "aws_apigatewayv2_domain_name.public",
         "aws_apigatewayv2_route.private_application",