Merge pull request #347 from mailgun/update-error-class

feature: Add type property to errors

Author: olexandr-mazepa

dist/error.d.ts

@@ -3,5 +3,6 @@ export default class APIError extends Error {
     status: number | string;
     stack: string;
     details: string;
+    type: string;
     constructor({ status, statusText, message, body }: APIErrorOptions);
 }

dist/mailgun.node.js

@@ -1,9 +1,10 @@
 import APIErrorOptions from './interfaces/APIErrorOptions';
 
 export default class APIError extends Error {
-  status: number | string;
-  stack: string;
-  details: string;
+  public status: number | string;
+  public stack: string;
+  public details: string;
+  public type: string;
 
   constructor({
     status,
@@ -25,5 +26,6 @@ export default class APIError extends Error {
     this.status = status;
     this.message = message || error || statusText;
     this.details = bodyMessage;
+    this.type = 'MailgunAPIError';
   }
 }

dist/mailgun.web.js

@@ -2,31 +2,46 @@ import APIError from '../lib/error';
 import APIErrorOptions from '../lib/interfaces/APIErrorOptions';
 
 describe('APIError', function () {
-  let error;
-
   it('sets status', function () {
-    error = new APIError({ status: 200 } as APIErrorOptions);
-
+    const error = new APIError({ status: 200 } as APIErrorOptions);
     error.status.should.eql(200);
   });
 
-  it('sets message from message field', function () {
-    error = new APIError({
-      body: {
-        message: 'oops. something went wrong'
-      }
-    } as APIErrorOptions);
+  describe('details property', () => {
+    it('sets details from message field', () => {
+      const error = new APIError({
+        body: {
+          message: 'oops. something went wrong'
+        }
+      } as APIErrorOptions);
 
-    error.details.should.eql('oops. something went wrong');
+      error.details.should.eql('oops. something went wrong');
+    });
+
+    it('sets details if body is a string', () => {
+      const error = new APIError({
+        body: 'oops. something went wrong'
+      } as APIErrorOptions);
+
+      error.details.should.eql('oops. something went wrong');
+    });
   });
 
-  it('sets message from error field', function () {
-    error = new APIError({
+  it('sets message from error field', () => {
+    const error = new APIError({
       body: {
         error: 'oops. something went wrong'
       }
     } as APIErrorOptions);
 
     error.message.should.eql('oops. something went wrong');
   });
+
+  it('Creates instance if no data', () => {
+    const error = new APIError({} as APIErrorOptions);
+    error.should.has.property('status');
+    error.should.has.property('message');
+    error.should.has.property('details');
+    error.type.should.eql('MailgunAPIError');
+  });
 });