diff --git a/tests/unit/test_version.py b/tests/unit/test_version.py index ca78569..2d9bf04 100644 --- a/tests/unit/test_version.py +++ b/tests/unit/test_version.py @@ -10,8 +10,9 @@ def test_version_length_equal_three() -> None: """Verifies standard version fetching returns a properly formatted string.""" version = get_version() - if version: - assert len(version.split(".")) >= 3 + assert version is not None + assert version != "" + assert len(version.split(".")) >= 3 def test_get_version_is_none() -> None: @@ -20,8 +21,8 @@ def test_get_version_is_none() -> None: sys.modules, {"pkg_resources": None, "importlib.metadata": None, "mailjet_rest": None}, ): - with suppress(Exception): - get_version() + version = get_version() + assert version is None def test_get_version() -> None: @@ -30,7 +31,7 @@ def test_get_version() -> None: def test_get_version_raises_exception() -> None: """Forces the version parser to hit its fallback exception blocks (ValueError, ImportError, etc.).""" - # By forcing a ValueError exception on the system path or modules, we hit lines 31-65. + # By forcing parser-related exceptions, verify get_version gracefully falls back. with patch( "mailjet_rest.utils.version.open", side_effect=ValueError("Forced ValueError for coverage"), @@ -38,8 +39,7 @@ def test_get_version_raises_exception() -> None: with patch.dict( sys.modules, {"pkg_resources": None, "importlib.metadata": None} ): - with suppress(Exception): - get_version() + assert get_version() is None with patch( "mailjet_rest.utils.version.open", @@ -48,5 +48,4 @@ def test_get_version_raises_exception() -> None: with patch.dict( sys.modules, {"pkg_resources": None, "importlib.metadata": None} ): - with suppress(Exception): - get_version() + assert get_version() is None