Skip to content

Download files from MyMiniFactory #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Floppy wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Download files from MyMiniFactory #4479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/deserializers/integrations/my_mini_factory/model_deserializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ def deserialize
name: r.body["name"],
notes: ReverseMarkdown.convert(r.body["description_html"]),
tag_list: r.body["tags"],
file_urls: r.body["images"].map { |it| {url: it.dig("original", "url"), filename: filename_from_url(it.dig("original", "url"))} },
file_urls: (r.body["images"].map { |it| {url: it.dig("original", "url"), filename: filename_from_url(it.dig("original", "url"))} } +
r.body.dig("files", "items").map { |it| {url: it.dig("download_url"), filename: it.dig("filename")} }),
preview_filename: filename_from_url(r.body["images"].find { |it| it["is_primary"] === true }&.dig("original", "url"))
}
end
Expand Down
7 changes: 7 additions & 0 deletions spec/deserializers/integrations/my_mini_factory/model_deserializer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@
})
end

it "extracts 3d file info to check and download" do
expect(deserializer.deserialize[:file_urls]).to include({
url: "https://www.myminifactory.com/download/2052?downloadfile=scan-the-world-michelangelo-s-david.stl",
filename: "scan-the-world-michelangelo-s-david.stl"
})
end

it "extracts preview filename" do
expect(deserializer.deserialize[:preview_filename]).to eq "david-2.jpg"
end
Expand Down
Loading