Skip to content

Conversation

@iliaplatone
Copy link

No description provided.

@e-n-f
Copy link
Contributor

e-n-f commented Dec 20, 2018

Thanks for the contribution. As you can see, the build is breaking due to the missing dependency, which will need to be installed in .travis.yml. Could you please also make indent to keep the formatting consistent with other source code? Thanks!

@e-n-f e-n-f changed the title Sky sight Use libdeflate instead of zlib Dec 20, 2018
Ilia Platone added 18 commits December 21, 2018 00:43
@iliaplatone
Copy link
Author

I made many commits, there is still an error during test phase, I think this is not an error of my code.
[code]
./tippecanoe -q -a@ -f -o tests/longlayer/out/-z0.json.check.mbtiles -z0 tests/longlayer/in.json < /dev/null
./tippecanoe-decode -x generator tests/longlayer/out/-z0.json.check.mbtiles > tests/longlayer/out/-z0.json.check.out
PBF decoding error in tile 0/0/0
make: *** [tests/longlayer/out/-z0.json.check] Error 1
The command "docker run -it tippecanoe-image" exited with 2.
[/code]

@e-n-f
Copy link
Contributor

e-n-f commented Dec 21, 2018

Thanks. I'll take a look and see if I can understand what is going wrong with that tile.

@Plantain
Copy link
Contributor

This won't build on OSX/Clang/llvm currently:
c++ -MMD -I/usr/local/include -I. -Ilibdeflate -g -O3 -DNDEBUG -std=c++11 -c -o mvt.o mvt.cpp
mvt.cpp:48:33: error: arithmetic on a pointer to void
next_out = (void *) (next_out + existing_output);
~~~~~~~~ ^

@Plantain
Copy link
Contributor

Interestingly the file sizes are coming out considerably larger with libdeflate. I am investigating why that might be.
-rw-r--r-- 1 plantain staff 1556480 21 Dec 18:07 out.mbtiles
-rw-r--r-- 1 plantain staff 1064960 21 Dec 17:37 out.old.mbtiles

@iliaplatone
Copy link
Author

Sorry for these commits, maybe this last commit will fix the compression error

@Plantain
Copy link
Contributor

The new commits have the void pointer arithmetic issue again:
mvt.cpp:84:33: error: arithmetic on a pointer to void
next_out = (void *) (next_out + increase);
~~~~~~~~ ^
mvt.cpp:85:31: error: arithmetic on a pointer to void
next_in = (void *) (next_in + increase * 2);
~~~~~~~ ^

@iliaplatone
Copy link
Author

Sorry for these commits, maybe this last commit will fix the compression error

@Plantain
Copy link
Contributor

Plantain commented Jan 4, 2019

This is not generating valid mbtiles in the current state - tiles generated are just hundreds of kb of null bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants