Skip to content

Conversation

@yan-hic
Copy link

@yan-hic yan-hic commented Nov 2, 2025

📝 Summary

Add a small UX enhancement to the data table: double‑clicking a cell adds a “filter by value” for that column. This reuses the existing filter mechanism and integrates with the filter pill UI.

🔍 Description of Changes

Add a minimal double‑click handler that:

  • No‑ops if the column cannot be filtered or lacks a filter type
  • Otherwise applies a select filter with the cell’s value using the existing Filter.select utility

Wire the handler to each table cell’s onDoubleClick

Behavior: Double‑clicking a cell creates a pill like “ is in []” and filters rows accordingly

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • [] I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Nov 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 2, 2025 2:08am

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@yan-hic
Copy link
Author

yan-hic commented Nov 2, 2025

I have read the CLA Document and I hereby sign the CLA

@mscolnick
Copy link
Contributor

hey @yan-hic - thank you for the contribution, we are going to discuss with the team to see if this is something we'd like to add/support

@yan-hic
Copy link
Author

yan-hic commented Nov 3, 2025

Hey Miles, how can I/you hold up on this? I like to propose another change instead namely a cell context menu to filter in or out (like Airtable). That would mean also adding the "is not in" filter operator.
Could add more operators like regex but it's probably best handled upstream, in another cell.

@mscolnick
Copy link
Contributor

adding a context menu could make sense as well. i think that is more intuitive than a double click anyways.

if we did add a context menu, we would need to support other commands like Copy and Copy Selected in case there are multiple cells selected.

Filter to include or exclude also makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants