-
Notifications
You must be signed in to change notification settings - Fork 812
data-table: double-click a cell to add a filter by value #7030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
data-table: double-click a cell to add a filter by value #7030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
9ee7e1f to
264eeb3
Compare
5ad2450 to
3c8b240
Compare
for more information, see https://pre-commit.ci
|
I have read the CLA Document and I hereby sign the CLA |
|
hey @yan-hic - thank you for the contribution, we are going to discuss with the team to see if this is something we'd like to add/support |
|
Hey Miles, how can I/you hold up on this? I like to propose another change instead namely a cell context menu to filter in or out (like Airtable). That would mean also adding the "is not in" filter operator. |
|
adding a context menu could make sense as well. i think that is more intuitive than a double click anyways. if we did add a context menu, we would need to support other commands like Filter to include or exclude also makes a lot of sense. |
📝 Summary
Add a small UX enhancement to the data table: double‑clicking a cell adds a “filter by value” for that column. This reuses the existing filter mechanism and integrates with the filter pill UI.
🔍 Description of Changes
Add a minimal double‑click handler that:
Wire the handler to each table cell’s onDoubleClick
Behavior: Double‑clicking a cell creates a pill like “ is in []” and filters rows accordingly
📋 Checklist