Skip to content

Commit 1be51d3

Browse files
committed
Note in readme
1 parent b5cfd0f commit 1be51d3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ Iterations = `double`s per op.
3434

3535
There is likely overhead in capturing hardware counters, so these should be more "correct"
3636

37+
NOTE - MWC256 is likely poorly implemented (it is supposed to be faster). As seen in the instrumented benchmark below there are a lot of branch mispredictions.
38+
This is clear from the generated assembly atm but I'm not sure why those branching instructions are generated. `UInt128` support is pretty new
39+
so maybe there are some inefficiencies there.
40+
3741
![Scaling iterations](/img/perf-scaling.png "Scaling iterations")
3842

3943
#### With hardware counters

src/Fast.PRNGs/Fast.PRNGs.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
1010
<PackageProjectUrl>https://github.com/martinothamar/Fast.PRNGs.NET</PackageProjectUrl>
1111
<RepositoryUrl>https://github.com/martinothamar/Fast.PRNGs.NET</RepositoryUrl>
12-
<PackageTags>csharp prng vectorization simd pseudorandom</PackageTags>
12+
<PackageTags>csharp prng vectorization simd pseudorandom random random-number-generators</PackageTags>
1313
<RepositoryType>git</RepositoryType>
1414
<Authors>Martin Othamar</Authors>
1515
<Copyright>Copyright 2023 Martin Othamar</Copyright>

0 commit comments

Comments
 (0)