Skip to content

Commit cde3a8b

Browse files
authored
Remove try gc during replay (#22210)
Remove try gc during replay Approved by: @XuPeng-SH
1 parent 0d42590 commit cde3a8b

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

pkg/vm/engine/tae/db/gc/v3/cleaner_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,15 @@ func TestDiskCleaner_WriteToReplay(t *testing.T) {
110110
diskCleaner.Start()
111111
err := diskCleaner.FlushQueue(context.Background())
112112
require.NoError(t, err)
113-
require.Equal(t, tryGC, 1)
113+
require.Equal(t, tryGC, 0)
114114
require.Equal(t, replayCnt, 1)
115115
require.Equal(t, executeCnt, 0)
116116

117117
err = diskCleaner.GC(context.Background())
118118
require.NoError(t, err)
119119
err = diskCleaner.FlushQueue(context.Background())
120120
require.NoError(t, err)
121-
require.Equal(t, tryGC, 1)
121+
require.Equal(t, tryGC, 0)
122122
require.Equal(t, replayCnt, 1)
123123
require.Equal(t, executeCnt, 1)
124124

pkg/vm/engine/tae/db/gc/v3/diskcleaner.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,6 @@ func (cleaner *DiskCleaner) doReplayAndExecute(ctx context.Context) (err error)
296296
if err = cleaner.doReplay(ctx); err != nil {
297297
return
298298
}
299-
msg = "GC-TryGC"
300-
err = cleaner.cleaner.TryGC(ctx)
301299
return
302300
}
303301

0 commit comments

Comments
 (0)