Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions _includes/getting-started.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ <h2 style>with Meshery</h2>
<div class="post-content row" itemprop="articleBody">

<div style="display: inline-flex; line-height: 60px;">
<h1 class="step-number" style="margin-right: 0.5rem">01</h1>
<h2 class="step-heading">Use Meshery Playground</h2>
<h1 class="step-number" style="margin-right: 0.3rem">01</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and adhere to best practices of separating structure (HTML) from presentation (CSS), please avoid using inline styles. The margin-right: 0.3rem should be moved to the .step-number class definition in your SCSS file. The same applies to line 22.

<h1 class="step-number">01</h1>

<h2 class="step-heading special-step">Use Meshery Playground</h2>
</div>
<p class="grey-bg-text" style="font-size: 1.15rem;">
<p class="grey-bg-text" style="font-size: 1.15rem; margin-top: 5px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please move the inline style margin-top: 5px; to the .grey-bg-text class in your SCSS file. This helps in keeping the styling separate from the HTML structure, making the code cleaner and easier to maintain. The same applies to line 25.

<p class="grey-bg-text" style="font-size: 1.15rem;">

The fastest way to put your hands on Meshery is in its playground. No installation required. Just click and go! <div class="button-para"><a class="highlight" href="https://play.meshery.io">Use Meshery Playground</a></div>
</p>
<hr />
<h2 class="step-heading" style="color: #222;justify-content: center;">OR</h2>
<hr />
<div style="display: inline-flex; line-height: 60px;">
<h1 class="step-number" style="margin-right: 0.5rem">01</h1>
<h1 class="step-number" style="margin-right: 0.3rem">01</h1>
<h2 class="step-heading">Choose Your Platform and Install</h2>
</div>
<p class="grey-bg-text" style="font-size: 1.15rem;">
<p class="grey-bg-text" style="font-size: 1.15rem; margin-top: 5px;">
Choose a platform and see how easy it is to start managing cloud native infrastructure with a single command.
</p>
<div class="platformIcon">
Expand Down
14 changes: 10 additions & 4 deletions _sass/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -466,11 +466,13 @@ hr {
border-radius: 3px;
}

.getting-started-heading {
.container > .getting-started-heading {
text-align: center;
white-space: nowrap;
font-size: clamp(40px, 7vw, 75px);
font-weight: bold;
font-size: 75px;
text-align: left;
margin-bottom:0px;
margin-bottom: 0;
letter-spacing: 1px;
}

.overview-heading {
Expand All @@ -492,6 +494,10 @@ hr {
.step-heading {
margin: 0;
font-weight: bold;
}

.special-step {
white-space: nowrap;
}

// responsive getting started
Expand Down
Loading