Fix groovy code format with linters #1150

Sunnatillo · 2025-11-06T12:44:54Z

This PR fixes jenkins pipeline code formats files with Groovy linters

Sunnatillo · 2025-11-06T12:48:42Z

lentzi90

Nice cleanup!
I added suggestions for cleaning up nested withCredentials also.
The quoting was a bit confusing for me first but it seems consistent. If the string contains variables, then " is used, otherwise '. Maybe it helps with accidental evaluation, I don't know but it is ok for me.

jenkins/jobs/dynamic_fullstack_building.groovy

jenkins/jobs/bml_integration_tests.groovy

Sunnatillo · 2025-11-10T08:41:21Z

Nice cleanup! I added suggestions for cleaning up nested withCredentials also. The quoting was a bit confusing for me first but it seems consistent. If the string contains variables, then " is used, otherwise '. Maybe it helps with accidental evaluation, I don't know but it is ok for me.

Thanks for review @lentzi90. I fixed all nested withCredentials issue as well.

lentzi90

/approve

adilGhaffarDev

/lgtm

Copilot

Pull Request Overview

This PR applies Groovy linter formatting fixes to Jenkins pipeline files and adds a linter configuration. The changes include standardizing indentation, converting double quotes to single quotes for static strings, adding type declarations to variables, removing unused imports, and restructuring nested credential blocks.

Adds .groovylintrc.json configuration file for Groovy linting
Standardizes code formatting across all Jenkins pipeline files (indentation, quotes, spacing)
Adds explicit type declarations to variables (string, int)
Flattens nested withCredentials blocks for better readability

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
.groovylintrc.json	Adds linter configuration with recommended rules and specific exclusions
jenkins/jobs/pre_release_tests.groovy	Formats code, adds type declarations, changes quotes to single quotes
jenkins/jobs/image_building.groovy	Formats code, adds type declarations, changes quotes to single quotes
jenkins/jobs/e2e_features_test.groovy	Formats code, renames TIMEOUT to buildTimeout, adds type declarations
jenkins/jobs/dynamic_fullstack_building.groovy	Formats code, renames TIMEOUT to buildTimeout, flattens credentials
jenkins/jobs/dev_env_integration_tests.groovy	Formats code, renames TIMEOUT to buildTimeout, adds type declarations
jenkins/jobs/clean_resources.groovy	Formats code, renames TIMEOUT to buildTimeout, adds type declarations
jenkins/jobs/capm3-e2e-tests.groovy	Formats code, renames TIMEOUT to buildTimeout
jenkins/jobs/bmo_e2e_optional_tests.groovy	Formats code, renames TIMEOUT to buildTimeout, adds type declarations
jenkins/jobs/bml_integration_tests.groovy	Formats code, changes BOOTSTRAP_CLUSTER to EPHEMERAL_CLUSTER, has syntax error

Comments suppressed due to low confidence (1)

jenkins/jobs/bmo_e2e_optional_tests.groovy:1

Variables declared with string type at script scope cannot be referenced later in the pipeline. In Groovy/Jenkins pipelines, script-level variables should be declared without explicit type annotations (use def or no qualifier). The string type is not valid for variable declarations in this context.

// 3 hour

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T17:29:47Z

jenkins/jobs/e2e_features_test.groovy

-  ci_git_url = "https://github.com/metal3-io/project-infra.git"
+    string UPDATED_REPO = "https://github.com/${env.REPO_OWNER}/${env.REPO_NAME}.git"
+    echo "Test triggered from ${UPDATED_REPO}"
+    string ci_git_url = 'https://github.com/metal3-io/project-infra.git'


Variables declared with string type at script scope cannot be referenced in the pipeline environment block (line 39). In Groovy/Jenkins pipelines, script-level variables should be declared without explicit type annotations (use def or no qualifier). The string type is not valid for variable declarations in this context.

Suggested change

string ci_git_url = 'https://github.com/metal3-io/project-infra.git'

def ci_git_url = 'https://github.com/metal3-io/project-infra.git'

Copilot · 2025-11-12T17:29:48Z

jenkins/jobs/dynamic_fullstack_building.groovy

+    string UPDATED_REPO = "https://github.com/${env.REPO_OWNER}/${env.REPO_NAME}.git"
+    echo "Test triggered from ${UPDATED_REPO}"
+    string ci_git_url = 'https://github.com/metal3-io/project-infra.git'


Variables declared with string type at script scope cannot be referenced in the pipeline environment block (line 31). In Groovy/Jenkins pipelines, script-level variables should be declared without explicit type annotations (use def or no qualifier). The string type is not valid for variable declarations in this context.

Suggested change

string UPDATED_REPO = "https://github.com/${env.REPO_OWNER}/${env.REPO_NAME}.git"

echo "Test triggered from ${UPDATED_REPO}"

string ci_git_url = 'https://github.com/metal3-io/project-infra.git'

def UPDATED_REPO = "https://github.com/${env.REPO_OWNER}/${env.REPO_NAME}.git"

echo "Test triggered from ${UPDATED_REPO}"

def ci_git_url = 'https://github.com/metal3-io/project-infra.git'

jenkins/jobs/dev_env_integration_tests.groovy

jenkins/jobs/clean_resources.groovy

Copilot · 2025-11-12T17:29:49Z

jenkins/jobs/capm3-e2e-tests.groovy

 script {
+    string  UPDATED_REPO = "https://github.com/${env.REPO_OWNER}/${env.REPO_NAME}.git"
+    echo "Test triggered from ${UPDATED_REPO}"
+    string ci_git_url = 'https://github.com/metal3-io/project-infra.git'


Variables declared with string type at script scope cannot be referenced later in the script. In Groovy/Jenkins pipelines, script-level variables should be declared without explicit type annotations (use def or no qualifier). The string type is not valid for variable declarations in this context.

Suggested change

string ci_git_url = 'https://github.com/metal3-io/project-infra.git'

def ci_git_url = 'https://github.com/metal3-io/project-infra.git'

jenkins/jobs/bml_integration_tests.groovy

Copilot · 2025-11-12T17:29:50Z

jenkins/jobs/bml_integration_tests.groovy

+                    archiveArtifacts "logs-${env.BUILD_TAG}.tgz"
+                }
+            }
            archiveArtifacts "logs-${env.BUILD_TAG}.tgz"


The archiveArtifacts call on line 105 is duplicated (also appears on line 102). This will cause the same artifacts to be archived twice. Remove the duplicate on line 105.

Suggested change

archiveArtifacts "logs-${env.BUILD_TAG}.tgz"

tuminoid · 2025-11-12T17:40:34Z

PTAL Copilot review @Sunnatillo

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jenkins/jobs/bml_integration_tests.groovy

jenkins/jobs/image_building.groovy

jenkins/jobs/bml_integration_tests.groovy

jenkins/jobs/pre_release_tests.groovy

jenkins/jobs/e2e_features_test.groovy

jenkins/jobs/bmo_e2e_optional_tests.groovy

Signed-off-by: Sunnatillo <[email protected]>

tuminoid · 2025-11-13T17:12:41Z

Added #1153 to add prow linter job for groovy after we merge this.

adilGhaffarDev

/lgtm

metal3-io-bot · 2025-11-20T12:39:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sunnatillo · 2025-11-20T12:52:17Z

/override metal3-ubuntu-e2e-integration-test-main

metal3-io-bot · 2025-11-20T12:52:22Z

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

metal3-io-bot requested review from elfosardo and tuminoid November 6, 2025 12:44

metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2025

metal3-io-bot requested a review from lentzi90 November 6, 2025 12:48

lentzi90 reviewed Nov 7, 2025

View reviewed changes

Sunnatillo force-pushed the Sunnatillo/lint-groovy-code branch from e5c1f96 to ac29806 Compare November 10, 2025 08:39

Sunnatillo force-pushed the Sunnatillo/lint-groovy-code branch 2 times, most recently from a149794 to c90c65d Compare November 10, 2025 09:19

lentzi90 reviewed Nov 10, 2025

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2025

adilGhaffarDev approved these changes Nov 10, 2025

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025

tuminoid requested a review from Copilot November 12, 2025 17:27

Copilot started reviewing on behalf of tuminoid November 12, 2025 17:27 View session

Copilot finished reviewing on behalf of tuminoid November 12, 2025 17:28

Copilot AI reviewed Nov 12, 2025

View reviewed changes

Sunnatillo force-pushed the Sunnatillo/lint-groovy-code branch from c90c65d to 8b7c3ac Compare November 12, 2025 21:24

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025

Sunnatillo force-pushed the Sunnatillo/lint-groovy-code branch 2 times, most recently from ec52fe6 to b64271f Compare November 12, 2025 21:34

Sunnatillo requested a review from Copilot November 13, 2025 06:56

Copilot started reviewing on behalf of Sunnatillo November 13, 2025 06:56 View session

Copilot finished reviewing on behalf of Sunnatillo November 13, 2025 06:58

Copilot AI reviewed Nov 13, 2025

View reviewed changes

Fix groovy code format with linters

2f314cf

Signed-off-by: Sunnatillo <[email protected]>

Sunnatillo force-pushed the Sunnatillo/lint-groovy-code branch from b64271f to 2f314cf Compare November 13, 2025 07:40

tuminoid mentioned this pull request Nov 13, 2025

Add groovy linter Prow job #1153

Open

adilGhaffarDev approved these changes Nov 20, 2025

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025

metal3-io-bot merged commit 872d9df into metal3-io:main Nov 20, 2025
6 checks passed

metal3-io-bot deleted the Sunnatillo/lint-groovy-code branch November 20, 2025 12:52

	string ci_git_url = 'https://github.com/metal3-io/project-infra.git'
	def ci_git_url = 'https://github.com/metal3-io/project-infra.git'

Fix groovy code format with linters #1150

Fix groovy code format with linters #1150

Uh oh!

Conversation

Sunnatillo commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sunnatillo commented Nov 6, 2025

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sunnatillo commented Nov 10, 2025

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

adilGhaffarDev left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

tuminoid commented Nov 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tuminoid commented Nov 13, 2025

Uh oh!

adilGhaffarDev left a comment

Choose a reason for hiding this comment

Uh oh!

metal3-io-bot commented Nov 20, 2025

Uh oh!

Sunnatillo commented Nov 20, 2025

Uh oh!

metal3-io-bot commented Nov 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sunnatillo commented Nov 6, 2025 •

edited

Loading