Skip to content

Commit df105ba

Browse files
committed
Update draft-ari references to RFC 9773
1 parent 47ab3b8 commit df105ba

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ In other words, the `acmez` package is **porcelain** while the `acme` package is
3333
- Device attestation challenges ([draft-acme-device-attest-02](https://datatracker.ietf.org/doc/draft-acme-device-attest/))
3434
- [RFC 8737](https://www.rfc-editor.org/rfc/rfc8737.html) (tls-alpn-01 challenge)
3535
- [RFC 8823](https://www.rfc-editor.org/rfc/rfc8823.html) (email-reply-00 challenge; S/MIME)
36-
- ACME Renewal Information (ARI) support ([draft-ietf-acme-ari-03](https://datatracker.ietf.org/doc/draft-ietf-acme-ari/))
36+
- ACME Renewal Information (ARI) support ([RFC 9773](https://datatracker.ietf.org/doc/html/rfc9773)
3737
- ACME profiles ([draft-aaron-acme-profiles](https://datatracker.ietf.org/doc/draft-aaron-acme-profiles/))
3838

3939

acme/ari.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ var ErrUnsupported = fmt.Errorf("unsupported by ACME server")
3434
// on when they should renew certificates."
3535
//
3636
// ACME Renewal Information (ARI):
37-
// https://www.ietf.org/archive/id/draft-ietf-acme-ari-03.html §4.2
37+
// https://datatracker.ietf.org/doc/html/rfc9773 §4.2
3838
//
3939
// This is a DRAFT specification and the API is subject to change.
4040
type RenewalInfo struct {
@@ -168,7 +168,7 @@ func (c *Client) GetRenewalInfo(ctx context.Context, leafCert *x509.Certificate)
168168
// timestamp), it SHOULD make its own determination of when to
169169
// renew the certificate, and MAY retry the renewalInfo request
170170
// with appropriate exponential backoff behavior."
171-
// draft-ietf-acme-ari-04 §4.2
171+
// RFC 9773 §4.2
172172
if ari.SuggestedWindow.Start.IsZero() ||
173173
ari.SuggestedWindow.End.IsZero() ||
174174
ari.SuggestedWindow.Start.Equal(ari.SuggestedWindow.End) ||
@@ -191,7 +191,7 @@ func (c *Client) GetRenewalInfo(ctx context.Context, leafCert *x509.Certificate)
191191
}
192192

193193
// "The server SHOULD include a Retry-After header indicating the polling
194-
// interval that the ACME server recommends." draft-ietf-acme-ari-03 §4.2
194+
// interval that the ACME server recommends." RFC 9773 §4.2
195195
raTime, err := retryAfterTime(resp)
196196
if err != nil && c.Logger != nil {
197197
c.Logger.LogAttrs(ctx, slog.LevelError, "invalid Retry-After value",
@@ -244,7 +244,6 @@ func (c *Client) ariEndpoint(ariCertID string) string {
244244

245245
// ARIUniqueIdentifier returns the unique identifier for the certificate
246246
// as used by ACME Renewal Information.
247-
// EXPERIMENTAL: ARI is a draft RFC spec: draft-ietf-acme-ari-03
248247
func ARIUniqueIdentifier(leafCert *x509.Certificate) (string, error) {
249248
if leafCert.SerialNumber == nil {
250249
return "", fmt.Errorf("no serial number")

acme/certificate.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func (c *Client) GetCertificateChain(ctx context.Context, account Account, certU
110110
Account: account.Location,
111111
}
112112

113-
// attach renewal information, if applicable (draft-ietf-acme-ari-03)
113+
// attach renewal information, if applicable (RFC 9773)
114114
if c.dir.RenewalInfo != "" {
115115
certDERBlock, _ := pem.Decode(chainPEM)
116116
if certDERBlock != nil && certDERBlock.Type == "CERTIFICATE" {

acme/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ type Directory struct {
177177
NewAuthz string `json:"newAuthz,omitempty"`
178178
RevokeCert string `json:"revokeCert"`
179179
KeyChange string `json:"keyChange"`
180-
RenewalInfo string `json:"renewalInfo,omitempty"` // draft-ietf-acme-ari
180+
RenewalInfo string `json:"renewalInfo,omitempty"` // RFC 9773
181181
Meta *DirectoryMeta `json:"meta,omitempty"`
182182
}
183183

acme/order.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ type Order struct {
5959
// this field in New Order requests if there is a clear predecessor
6060
// certificate, as is the case for most certificate renewals.
6161
//
62-
// EXPERIMENTAL: Draft ACME extension ARI: draft-ietf-acme-ari-03
62+
// ACME extension ARI: RFC 9773 §5
6363
Replaces string `json:"replaces,omitempty"`
6464

6565
// notBefore (optional, string): The requested value of the notBefore

0 commit comments

Comments
 (0)