review of units excuses

[turbomam]

@mslarae13 (Montana) reviewed 18 slots in units/output/schema_units_excuses.tsv and added two columns with detailed analysis:

1. Suggested units or range changes
2. Decision notes and next steps

Her Key Recommendations Were Captured in Multiple Places:

1. Two Issues Created to Act on Her Analysis:

• Issue add storage_units annotations for the slots that were reviewed in PR #2653 #2686: "add storage_units annotations for the slots that were reviewed in PR Evaluate slot excuses for UCUM #2653"
  • For slots that CAN have UCUM units added
• Issue non-storage-units solutions for slots with excuses #2687: "non-storage-units solutions for slots with excuses"
  • For slots that need range changes or other solutions

2. Two PRs Implementing Her Recommendations:

• PR Add storage_units annotations for 7 slots reviewed in PR #2653 #2689 (OPEN): "Add storage_units annotations for 7 slots reviewed in PR Evaluate slot excuses for UCUM #2653"
  • Adds storage_units for: bulk_elect_conductivity, container_size, filter_pore_size, input_volume, specific_humidity, substances_volume, tvdss_of_hcr_temp
• PR Start improving slots that had units excuses #2690 (OPEN): "Start improving slots that had units excuses"
  • Adds storage_units for: exp_pipe, occup_density_samp
  • Makes biomaterial_purity and concentration abstract (as she suggested)

3. Two MIxS Issues Created (as she recommended):

• MIxS Issue Assert type slot on NEON classes #1066: "efficiency_percent gives mixed messages about the preferred units"
  • Her recommendation: "submit a ticket to MIxS about % vs umol/L" ✅ Done!
• MIxS Issue type slot assertion on planned NEON process classes and processed sample #1067: "rel_humidity_out implies that the preferred units are just masses of air"
  • Her recommendation: "should this be percent? open unit, submit a ticket to MIxS" ✅ Done!

4. Documented in Multiple Locations:

• units/docs/units-problems-definitive.md: Her insights are incorporated throughout, especially in sections about pending_analysis, mixs_inconsistent, complex_unit, and non_ucum_unit
  categories
• Issue non-storage-units solutions for slots with excuses #2687 comments: Your comments include detailed tables tracking the status of each of her recommendations

Her Specific Insights (from the PR diff):

Slot	Her Suggested Unit	Her Notes
api	degrees API	no UCUM unit, could add regex but nothing we can apply for UCUM. Could use attribute value.
biomaterial_purity	float	also, this slot isn't used as is as far as I know. Should be marked abstract
bulk_elect_conductivity	mS/cm	mS/cm = milliSiemens/centimeter. UCUM has Siemens as S, but no milliSiemens. Mark will look at this
concentration	%	2 child slots are %, I'm not sure we use concentration on any classes, likely just the children
container_size	mL	volume
efficiency_percent	umol/L	submit a ticket to MIxS about % vs umol/L
exp_pipe	float	this is just number of exposed pipes and pipes would be redundant as a unit.
filter_pore_size	um	micrometer
input_volume	mL	volume
inside_lux	kW/m2	kilowatt per square metre (B[kW] (bel kilowatt) ?)
microbial_biomass		not a QuantityValue
occup_density_samp	float
rel_humidity_out		should this be percent? open unit, submit a ticket to MIxS
soil_text_measure		not a QuantityValue
specific_humidity	g/kg	I think MIxS just has this written weirdly.. should be grams of water vapor per kilogram of air (g/kg)
substances_volume	mL	volume
tvdss_of_hcr_temp	m	this is depth like soil depth but it's where a measurement was taken
value		what class is this slot on?, left over. Ignore.

Current Status (from Issue #2687):

✅ Fully Addressed (9 slots):

• bulk_elect_conductivity, container_size, filter_pore_size, input_volume, specific_humidity, substances_volume, tvdss_of_hcr_temp (PR Add storage_units annotations for 7 slots reviewed in PR #2653 #2689)
• exp_pipe, occup_density_samp, biomaterial_purity, concentration (PR Start improving slots that had units excuses #2690)

⏳ Still Requiring Attention (7 slots):

1. api - Change range from QuantityValue to float
2. efficiency_percent - Blocked on MIxS Assert type slot on NEON classes #1066
3. inside_lux - Needs clarification on lx vs kW/m2
4. microbial_biomass - Change range to string or TextValue
5. rel_humidity_out - Blocked on MIxS type slot assertion on planned NEON process classes and processed sample #1067
6. soil_text_measure - Change range to string or TextValue
7. value - Pending analysis/decision

Conclusion: Her insights were thoroughly captured and documented across issues #2686, #2687, PRs #2689, #2690, MIxS issues #1066 and #1067, and the comprehensive
units/docs/units-problems-definitive.md documentation file.

[turbomam]

we are waiting on migrators for PRs #2690 and #2689

[mslarae13]

Put in a separate PR to change anything that doesn't have a storage unit to not be a QV