GH Actions: only run PHPCS once + update CS dependencies #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DealerDirect PHPCS Composer plugin has released version 1.0 quite a while ago. And if updating that, might as well update PHPCS as well.
All sniffs from PHPCS are set up to give the same results independently of the PHP version on which PHPCS is run, so there is no need to run it against multiple PHP versions in the matrix. With this in mind, I'm suggesting to split off the PHPCS check into its own job. Within that job, I've also set things up in a way that any CS errors will be shown inline in the code view if the build was run for a PR.
Member
|
LGTM! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: update some CS dependencies
The DealerDirect PHPCS Composer plugin has released version 1.0 quite a while ago. And if updating that, might as well update PHPCS as well.
GH Actions: only run PHPCS once
All sniffs from PHPCS are set up to give the same results independently of the PHP version on which PHPCS is run, so there is no need to run it against multiple PHP versions in the matrix.
With this in mind, I'm suggesting to split off the PHPCS check into its own job.
Within that job, I've also set things up in a way that any CS errors will be shown inline in the code view if the build was run for a PR.